mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ramanpreet Nara
4c5182c1cc
Summary: ## Context A React Native application can configure its RCTNetworking by initializing it with id<RCTURLRequestHandler> objects. Therefore, RCTNetworking supports this initializer: ``` - (instancetype)initWithHandlersProvider:(NSArray<id<RCTURLRequestHandler>> * (^)(void))getHandlers ``` Right now, all id<RCTURLRequestHandler> are NativeModules. So, they need to be loaded using the Bridge/TurboModuleManager. ## Problem The method [that constructs RCTNetworking](https://www.internalfb.com/code/fbsource/[6530647879a5e6d5edcfad029b39879c87e97bb3]/fbobjc/Apps/Wilde/FBReactModule2/FBReactModuleAPI/FBReactModuleAPI/FBReactModule.mm?lines=1471) is shared between bridge mode and bridgeless mode. So, the shared constructor needs to know what infra to use to load the request handlers: the TurboModuleManager, when called from a bridgeless context; the bridge, when called from a bridge context. There's no easy way to let this shared constructor know what context it's being called from. We could fork the constructor, but that's not very clean. ## Changes In this refactor, RCTNetworking gives its _handlersProvider its RCTModuleRegistry. If the module was instantiated in bridgeless mode, RCTModuleRegistry will use the TurboModuleManager. If the module was instantiated in bridge mode, RCTModuleRegistry will use the bridge. Using RCTModuleRegistry allows the _handlersProvider to load id<RCTURLRequestHandler> from correct infra, in both contexts. Changelog: [iOS][Changed] - Give RCTNetworking handler provider block RCTModuleRegistry Reviewed By: PeteTheHeat Differential Revision: D28013000 fbshipit-source-id: 956d660771ab18f5e7f24fcc28792f9a217146e7
74 lines
2.6 KiB
Objective-C
74 lines
2.6 KiB
Objective-C
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <React/RCTEventEmitter.h>
|
|
#import <React/RCTNetworkTask.h>
|
|
#import <React/RCTURLRequestHandler.h>
|
|
|
|
@protocol RCTNetworkingRequestHandler <NSObject>
|
|
|
|
// @lint-ignore FBOBJCUNTYPEDCOLLECTION1
|
|
- (BOOL)canHandleNetworkingRequest:(NSDictionary *)data;
|
|
// @lint-ignore FBOBJCUNTYPEDCOLLECTION1
|
|
- (NSDictionary *)handleNetworkingRequest:(NSDictionary *)data;
|
|
|
|
@end
|
|
|
|
@protocol RCTNetworkingResponseHandler <NSObject>
|
|
|
|
- (BOOL)canHandleNetworkingResponse:(NSString *)responseType;
|
|
- (id)handleNetworkingResponse:(NSURLResponse *)response data:(NSData *)data;
|
|
|
|
@end
|
|
|
|
@interface RCTNetworking : RCTEventEmitter
|
|
|
|
/**
|
|
* Allows RCTNetworking instances to be initialized with handlers.
|
|
* The handlers will be requested via the bridge's moduleForName method when required.
|
|
*/
|
|
- (instancetype)initWithHandlersProvider:(NSArray<id<RCTURLRequestHandler>> * (^)(RCTModuleRegistry *))getHandlers;
|
|
|
|
/**
|
|
* Does a handler exist for the specified request?
|
|
*/
|
|
- (BOOL)canHandleRequest:(NSURLRequest *)request;
|
|
|
|
/**
|
|
* Return an RCTNetworkTask for the specified request. This is useful for
|
|
* invoking the React Native networking stack from within native code.
|
|
*/
|
|
- (RCTNetworkTask *)networkTaskWithRequest:(NSURLRequest *)request
|
|
completionBlock:(RCTURLRequestCompletionBlock)completionBlock;
|
|
|
|
- (void)addRequestHandler:(id<RCTNetworkingRequestHandler>)handler;
|
|
|
|
- (void)addResponseHandler:(id<RCTNetworkingResponseHandler>)handler;
|
|
|
|
- (void)removeRequestHandler:(id<RCTNetworkingRequestHandler>)handler;
|
|
|
|
- (void)removeResponseHandler:(id<RCTNetworkingResponseHandler>)handler;
|
|
|
|
@end
|
|
|
|
@interface RCTBridge (RCTNetworking)
|
|
|
|
@property (nonatomic, readonly) RCTNetworking *networking;
|
|
|
|
@end
|
|
|
|
// HACK: When uploading images/video from PHAssetLibrary, we change the URL scheme to be
|
|
// ph-upload://. This is to ensure that we upload a full video when given a ph-upload:// URL,
|
|
// instead of just the thumbnail. Consider the following problem:
|
|
// The user has a video in their camera roll with URL ph://1B3E2DDB-0AD3-4E33-A7A1-9F4AA9A762AA/L0/001
|
|
// 1. We want to display that video in an <Image> and show the thumbnail
|
|
// 2. We later want to upload that video.
|
|
// At this point, if we use the same URL for both uses, there is no way to distinguish the intent
|
|
// and we will either upload the thumbnail (bad!) or try to show the video in an <Image> (bad!).
|
|
// Our solution is to change the URL scheme in the uploader.
|
|
extern NSString *const RCTNetworkingPHUploadHackScheme;
|