mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
2a21d5a28e
Summary: Fixes Xcode release builds when Hermes is enabled. The Hermes debugger is loaded by the Hermes executor only if HERMES_ENABLE_DEBUGGER is defined. The hermes-engine Pod would set `HERMES_ENABLE_DEBUGGER=0` in release builds, but of course this would satisfy the HERMES_ENABLE_DEBUGGER ifdef check, leading to build time issues due to missing `hermes::debugger` symbols. Now, both the `hermes-engine` and `React-hermes` pods only set `HERMES_ENABLE_DEBUGGER=1` in debug builds. No gcc preprocessor definition is added by these pods in release builds. Changelog: [iOS] [Changed] - Do not load Hermes inspector in release builds Reviewed By: cipolleschi Differential Revision: D40077503 fbshipit-source-id: dd9ce148e8521fc4e43e47e90f29ba8f7c9b7e4a