mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Anandraj Govindan
9d08d55bbe
Summary: CMake on Windows uses "Visual Studio **" generators are [multi-configuration](https://cgold.readthedocs.io/en/latest/glossary/multi-config.html), which requires the hermes cli and hermes runtime build flavors to be compatible. Using the "MakeFile" generator will avoid the requirement and keeps the gradle script simpler. Please note that the "Makefile" generator is the default when only "Visual Studio Community edition" with default packages is available. Use NMake generator for Hermes build on Windows ## Changelog CMake on Windows uses "Visual Studio **" generators are [multi-configuration](https://cgold.readthedocs.io/en/latest/glossary/multi-config.html), which requires the hermes cli and hermes runtime build flavors to be compatible. Using the "MakeFile" generator will avoid the requirement and keeps the gradle script simpler. Please note that the "Makefile" generator is the default when only "Visual Studio Community edition" with default packages is available. [Android] [Fixed] - Use NMake generator for Hermes build on Windows Pull Request resolved: https://github.com/facebook/react-native/pull/34790 Test Plan: Verified that RN build on Windows with multiple SKUs of Visual studio.d Reviewed By: cortinico Differential Revision: D39889332 Pulled By: cortinico fbshipit-source-id: f2d39d981e7c58c8cb93a4322155c844cb6bded3