mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Gabriel Donadel Dall'Agnol
14c91cdf59
Summary: This updates `aspectRatio` to support string values and ratio formats, i.e., `'16 / 9'`, thus aligning it with the [CSS Box Sizing Module Level 4](https://drafts.csswg.org/css-sizing-4/#aspect-ratio) specification as requested on https://github.com/facebook/react-native/issues/34425. This also adds unit tests to the `processAspectRatio` function ensuring the style processing works as expected. ## Changelog [General] [Added] - Add string support for aspectRatio Pull Request resolved: https://github.com/facebook/react-native/pull/34629 Test Plan: This can be tested either through `processAspectRatio-tests` or by using the following code: ```js <View style={{ backgroundColor: '#527FE4', aspectRatio: '16 / 9', }} /> ``` https://user-images.githubusercontent.com/11707729/189029904-da1dc0a6-85de-46aa-8ec2-3567802c8719.mov Reviewed By: jacdebug Differential Revision: D39423304 Pulled By: cipolleschi fbshipit-source-id: d323de93d6524e411e7ab9943335a8ca323b6e61
54 lines
1.2 KiB
JavaScript
54 lines
1.2 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @flow
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const invariant = require('invariant');
|
|
|
|
function processAspectRatio(aspectRatio: number | string): ?number {
|
|
if (typeof aspectRatio === 'number') {
|
|
return aspectRatio;
|
|
}
|
|
|
|
const matches = aspectRatio.split('/').map(s => s.trim());
|
|
|
|
if (matches.includes('auto')) {
|
|
if (__DEV__) {
|
|
invariant(
|
|
matches.length,
|
|
'aspectRatio does not support `auto <ratio>`. You passed: %s',
|
|
aspectRatio,
|
|
);
|
|
}
|
|
return;
|
|
}
|
|
|
|
const hasNonNumericValues = matches.some(n => Number.isNaN(Number(n)));
|
|
if (__DEV__) {
|
|
invariant(
|
|
!hasNonNumericValues && (matches.length === 1 || matches.length === 2),
|
|
'aspectRatio must either be a number, a ratio or `auto`. You passed: %s',
|
|
aspectRatio,
|
|
);
|
|
}
|
|
|
|
if (hasNonNumericValues) {
|
|
return;
|
|
}
|
|
|
|
if (matches.length === 2) {
|
|
return Number(matches[0]) / Number(matches[1]);
|
|
}
|
|
|
|
return Number(matches[0]);
|
|
}
|
|
|
|
module.exports = processAspectRatio;
|