mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin Shergin
e271fa190d
Summary: This diff changes how we apply default text attributes to backed text input. The original change in https://github.com/facebook/react-native/pull/23585 that introduced the `reactTextAttributes` field in for RCTBackedTextInputViewProtocol was great! Thank you Wu zhongwuzw ! However, there is one detail that needs to be changed. RCTBackedTextInputViewProtocol is designed to only abstract complexity of iOS text input components (UITextView and UITextField); it intentionally does not have any React-specific fields or types. Adding a field `RCTTextAttributes *reactTextAttributes;` violates this principle and make it hard to reuse this functionality in the new Fabric-powered TextInput. This diff changes the type of this prop from `RCTTextAttributes` to `NSDictionary<NSAttributedStringKey,id> *` (exact same type that UITextView and UITextField use). Reviewed By: cpojer Differential Revision: D17408501 fbshipit-source-id: 65f2bba119ccc30f22e87c28d0f8ea6f731cd365
46 lines
2.0 KiB
Objective-C
46 lines
2.0 KiB
Objective-C
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <UIKit/UIKit.h>
|
|
|
|
@protocol RCTBackedTextInputDelegate;
|
|
@class RCTTextAttributes;
|
|
|
|
NS_ASSUME_NONNULL_BEGIN
|
|
|
|
@protocol RCTBackedTextInputViewProtocol <UITextInput>
|
|
|
|
@property (nonatomic, strong, nullable) UIColor *textColor;
|
|
@property (nonatomic, strong, nullable) UIFont *font;
|
|
@property (nonatomic, copy, nullable) NSAttributedString *attributedText;
|
|
@property (nonatomic, copy, nullable) NSString *placeholder;
|
|
@property (nonatomic, strong, nullable) UIColor *placeholderColor;
|
|
@property (nonatomic, assign) NSTextAlignment textAlignment;
|
|
@property (nonatomic, assign, readonly) BOOL textWasPasted;
|
|
@property (nonatomic, assign) UIEdgeInsets textContainerInset;
|
|
@property (nonatomic, strong, nullable) UIView *inputAccessoryView;
|
|
@property (nonatomic, weak, nullable) id<RCTBackedTextInputDelegate> textInputDelegate;
|
|
@property (nonatomic, readonly) CGSize contentSize;
|
|
@property (nonatomic, strong, nullable) NSDictionary<NSAttributedStringKey,id> *defaultTextAttributes;
|
|
|
|
// This protocol disallows direct access to `selectedTextRange` property because
|
|
// unwise usage of it can break the `delegate` behavior. So, we always have to
|
|
// explicitly specify should `delegate` be notified about the change or not.
|
|
// If the change was initiated programmatically, we must NOT notify the delegate.
|
|
// If the change was a result of user actions (like typing or touches), we MUST notify the delegate.
|
|
- (void)setSelectedTextRange:(nullable UITextRange *)selectedTextRange NS_UNAVAILABLE;
|
|
- (void)setSelectedTextRange:(nullable UITextRange *)selectedTextRange notifyDelegate:(BOOL)notifyDelegate;
|
|
|
|
// This protocol disallows direct access to `text` property because
|
|
// unwise usage of it can break the `attributeText` behavior.
|
|
// Use `attributedText.string` instead.
|
|
@property (nonatomic, copy, nullable) NSString *text NS_UNAVAILABLE;
|
|
|
|
@end
|
|
|
|
NS_ASSUME_NONNULL_END
|