mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37473 ## Context The TurboModule system uses a CallInvoker interface to schedule JavaScript → native, and native → JavaScript calls. ## Problem JavaScript → native and native → JavaScript calls are different. They can have different behaviours/properties. And, in the future, we might want to evolve them differently. e.g: - JavaScript → native **always** have a method name. Native → JavaScript calls don't. - Native → JavaScript can have priorities, since D41492849. JavaScript → native don't. ## Changes Instead of tying both types of calls to the CallInvoker abstraction, this diff creates a **separate** abstraction for Native → JavaScript calls: NativeMethodCallInvoker. This way, we can evolve both abstractions separately over time: - We can evolve the CallInvoker abstraction to suit the needs of JavaScript → native calls. - We can evolve the NativeMethodCallInvoker abstraction to suite the needs of native → JavaScript calls. This ultimately makes TurboModule system more extensible. ## Motivation For the TurboModule interop layer on iOS, React Native needs to execute the "constantsToExport" method on the main queue, when the module requires main queue setup. (implementation: D45924977). The simplest way to implement this behaviour is to introduce a `methodName` to CallInvoker, and customize the legacy module's CallInvoker::invokeSync method, like so: ``` void invokeSync(std::string methodName, std::function<void()> &&work) override { if (requiresMainQueueSetup_ && methodName == "getConstants") { __block auto retainedWork = std::move(work); RCTUnsafeExecuteOnMainQueueSync(^{ retainedWork(); }); return; } work(); } ``` But, customizing CallInvoker to introduce a `methodName` parameter doesn't make sense: Native → JavaScript calls don't necessarily have method names. So, this diff forks CallInvoker into NativeMethodCallInvoker. That way, we can customize NativeMethodCallInvoker to introduce a method name (which does make sense) and resolve this problem. For the full solution, see D45924977. NOTE: Now that NativeMethodCallInvoker is different from CallInvoker, it might make sense to re-name CallInvoker back to JSCallInvoker. Changelog: [Category][Breaking] - Introduce NativeMethodCallInvoker to replace the TurboModule system's native CallInvoker Reviewed By: javache Differential Revision: D45891627 fbshipit-source-id: 39c3f450a290ad396b715288a50858d33ce78441
297 lines
9.2 KiB
C++
297 lines
9.2 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "Instance.h"
|
|
|
|
#include "ErrorUtils.h"
|
|
#include "JSBigString.h"
|
|
#include "JSBundleType.h"
|
|
#include "JSExecutor.h"
|
|
#include "MessageQueueThread.h"
|
|
#include "MethodCall.h"
|
|
#include "NativeToJsBridge.h"
|
|
#include "RAMBundleRegistry.h"
|
|
#include "RecoverableError.h"
|
|
#include "SystraceSection.h"
|
|
|
|
#include <cxxreact/JSIndexedRAMBundle.h>
|
|
#include <folly/MoveWrapper.h>
|
|
#include <folly/json.h>
|
|
|
|
#include <glog/logging.h>
|
|
|
|
#include <condition_variable>
|
|
#include <exception>
|
|
#include <memory>
|
|
#include <mutex>
|
|
#include <string>
|
|
|
|
namespace facebook::react {
|
|
|
|
Instance::~Instance() {
|
|
if (nativeToJsBridge_) {
|
|
nativeToJsBridge_->destroy();
|
|
}
|
|
}
|
|
|
|
void Instance::initializeBridge(
|
|
std::unique_ptr<InstanceCallback> callback,
|
|
std::shared_ptr<JSExecutorFactory> jsef,
|
|
std::shared_ptr<MessageQueueThread> jsQueue,
|
|
std::shared_ptr<ModuleRegistry> moduleRegistry) {
|
|
callback_ = std::move(callback);
|
|
moduleRegistry_ = std::move(moduleRegistry);
|
|
jsQueue->runOnQueueSync([this, &jsef, jsQueue]() mutable {
|
|
nativeToJsBridge_ = std::make_shared<NativeToJsBridge>(
|
|
jsef.get(), moduleRegistry_, jsQueue, callback_);
|
|
|
|
nativeToJsBridge_->initializeRuntime();
|
|
|
|
/**
|
|
* After NativeToJsBridge is created, the jsi::Runtime should exist.
|
|
* Also, the JS message queue thread exists. So, it's safe to
|
|
* schedule all queued up js Calls.
|
|
*/
|
|
jsCallInvoker_->setNativeToJsBridgeAndFlushCalls(nativeToJsBridge_);
|
|
|
|
std::lock_guard<std::mutex> lock(m_syncMutex);
|
|
m_syncReady = true;
|
|
m_syncCV.notify_all();
|
|
});
|
|
|
|
CHECK(nativeToJsBridge_);
|
|
}
|
|
|
|
void Instance::loadBundle(
|
|
std::unique_ptr<RAMBundleRegistry> bundleRegistry,
|
|
std::unique_ptr<const JSBigString> string,
|
|
std::string sourceURL) {
|
|
callback_->incrementPendingJSCalls();
|
|
SystraceSection s("Instance::loadBundle", "sourceURL", sourceURL);
|
|
nativeToJsBridge_->loadBundle(
|
|
std::move(bundleRegistry), std::move(string), std::move(sourceURL));
|
|
}
|
|
|
|
void Instance::loadBundleSync(
|
|
std::unique_ptr<RAMBundleRegistry> bundleRegistry,
|
|
std::unique_ptr<const JSBigString> string,
|
|
std::string sourceURL) {
|
|
std::unique_lock<std::mutex> lock(m_syncMutex);
|
|
m_syncCV.wait(lock, [this] { return m_syncReady; });
|
|
|
|
SystraceSection s("Instance::loadBundleSync", "sourceURL", sourceURL);
|
|
nativeToJsBridge_->loadBundleSync(
|
|
std::move(bundleRegistry), std::move(string), std::move(sourceURL));
|
|
}
|
|
|
|
void Instance::setSourceURL(std::string sourceURL) {
|
|
callback_->incrementPendingJSCalls();
|
|
SystraceSection s("Instance::setSourceURL", "sourceURL", sourceURL);
|
|
|
|
nativeToJsBridge_->loadBundle(nullptr, nullptr, std::move(sourceURL));
|
|
}
|
|
|
|
void Instance::loadScriptFromString(
|
|
std::unique_ptr<const JSBigString> string,
|
|
std::string sourceURL,
|
|
bool loadSynchronously) {
|
|
SystraceSection s("Instance::loadScriptFromString", "sourceURL", sourceURL);
|
|
if (loadSynchronously) {
|
|
loadBundleSync(nullptr, std::move(string), std::move(sourceURL));
|
|
} else {
|
|
loadBundle(nullptr, std::move(string), std::move(sourceURL));
|
|
}
|
|
}
|
|
|
|
void Instance::loadRAMBundleFromString(
|
|
std::unique_ptr<const JSBigString> script,
|
|
const std::string &sourceURL) {
|
|
auto bundle = std::make_unique<JSIndexedRAMBundle>(std::move(script));
|
|
auto startupScript = bundle->getStartupCode();
|
|
auto registry = RAMBundleRegistry::singleBundleRegistry(std::move(bundle));
|
|
loadRAMBundle(std::move(registry), std::move(startupScript), sourceURL, true);
|
|
}
|
|
|
|
void Instance::loadRAMBundleFromFile(
|
|
const std::string &sourcePath,
|
|
const std::string &sourceURL,
|
|
bool loadSynchronously) {
|
|
auto bundle = std::make_unique<JSIndexedRAMBundle>(sourcePath.c_str());
|
|
auto startupScript = bundle->getStartupCode();
|
|
auto registry = RAMBundleRegistry::multipleBundlesRegistry(
|
|
std::move(bundle), JSIndexedRAMBundle::buildFactory());
|
|
loadRAMBundle(
|
|
std::move(registry),
|
|
std::move(startupScript),
|
|
sourceURL,
|
|
loadSynchronously);
|
|
}
|
|
|
|
void Instance::loadRAMBundle(
|
|
std::unique_ptr<RAMBundleRegistry> bundleRegistry,
|
|
std::unique_ptr<const JSBigString> startupScript,
|
|
std::string startupScriptSourceURL,
|
|
bool loadSynchronously) {
|
|
if (loadSynchronously) {
|
|
loadBundleSync(
|
|
std::move(bundleRegistry),
|
|
std::move(startupScript),
|
|
std::move(startupScriptSourceURL));
|
|
} else {
|
|
loadBundle(
|
|
std::move(bundleRegistry),
|
|
std::move(startupScript),
|
|
std::move(startupScriptSourceURL));
|
|
}
|
|
}
|
|
|
|
void Instance::setGlobalVariable(
|
|
std::string propName,
|
|
std::unique_ptr<const JSBigString> jsonValue) {
|
|
nativeToJsBridge_->setGlobalVariable(
|
|
std::move(propName), std::move(jsonValue));
|
|
}
|
|
|
|
void *Instance::getJavaScriptContext() {
|
|
return nativeToJsBridge_ ? nativeToJsBridge_->getJavaScriptContext()
|
|
: nullptr;
|
|
}
|
|
|
|
bool Instance::isInspectable() {
|
|
return nativeToJsBridge_ ? nativeToJsBridge_->isInspectable() : false;
|
|
}
|
|
|
|
bool Instance::isBatchActive() {
|
|
return nativeToJsBridge_ ? nativeToJsBridge_->isBatchActive() : false;
|
|
}
|
|
|
|
void Instance::callJSFunction(
|
|
std::string &&module,
|
|
std::string &&method,
|
|
folly::dynamic &¶ms) {
|
|
callback_->incrementPendingJSCalls();
|
|
nativeToJsBridge_->callFunction(
|
|
std::move(module), std::move(method), std::move(params));
|
|
}
|
|
|
|
void Instance::callJSCallback(uint64_t callbackId, folly::dynamic &¶ms) {
|
|
SystraceSection s("Instance::callJSCallback");
|
|
callback_->incrementPendingJSCalls();
|
|
nativeToJsBridge_->invokeCallback((double)callbackId, std::move(params));
|
|
}
|
|
|
|
void Instance::registerBundle(
|
|
uint32_t bundleId,
|
|
const std::string &bundlePath) {
|
|
nativeToJsBridge_->registerBundle(bundleId, bundlePath);
|
|
}
|
|
|
|
const ModuleRegistry &Instance::getModuleRegistry() const {
|
|
return *moduleRegistry_;
|
|
}
|
|
|
|
ModuleRegistry &Instance::getModuleRegistry() {
|
|
return *moduleRegistry_;
|
|
}
|
|
|
|
void Instance::handleMemoryPressure(int pressureLevel) {
|
|
if (nativeToJsBridge_) {
|
|
// This class resets `nativeToJsBridge_` only in the destructor,
|
|
// hence a race is not possible there.
|
|
nativeToJsBridge_->handleMemoryPressure(pressureLevel);
|
|
}
|
|
}
|
|
|
|
std::shared_ptr<CallInvoker> Instance::getJSCallInvoker() {
|
|
return std::static_pointer_cast<CallInvoker>(jsCallInvoker_);
|
|
}
|
|
|
|
RuntimeExecutor Instance::getRuntimeExecutor() {
|
|
std::weak_ptr<NativeToJsBridge> weakNativeToJsBridge = nativeToJsBridge_;
|
|
|
|
auto runtimeExecutor =
|
|
[weakNativeToJsBridge](
|
|
std::function<void(jsi::Runtime & runtime)> &&callback) {
|
|
if (auto strongNativeToJsBridge = weakNativeToJsBridge.lock()) {
|
|
strongNativeToJsBridge->runOnExecutorQueue(
|
|
[callback = std::move(callback)](JSExecutor *executor) {
|
|
jsi::Runtime *runtime =
|
|
(jsi::Runtime *)executor->getJavaScriptContext();
|
|
try {
|
|
callback(*runtime);
|
|
executor->flush();
|
|
} catch (jsi::JSError &originalError) {
|
|
handleJSError(*runtime, originalError, true);
|
|
}
|
|
});
|
|
}
|
|
};
|
|
return runtimeExecutor;
|
|
}
|
|
|
|
std::shared_ptr<NativeMethodCallInvoker>
|
|
Instance::getDecoratedNativeMethodCallInvoker(
|
|
std::shared_ptr<NativeMethodCallInvoker> nativeMethodCallInvoker) {
|
|
return nativeToJsBridge_->getDecoratedNativeMethodCallInvoker(
|
|
nativeMethodCallInvoker);
|
|
}
|
|
|
|
void Instance::JSCallInvoker::setNativeToJsBridgeAndFlushCalls(
|
|
std::weak_ptr<NativeToJsBridge> nativeToJsBridge) {
|
|
std::lock_guard<std::mutex> guard(m_mutex);
|
|
|
|
m_shouldBuffer = false;
|
|
m_nativeToJsBridge = nativeToJsBridge;
|
|
while (m_workBuffer.size() > 0) {
|
|
scheduleAsync(std::move(m_workBuffer.front()));
|
|
m_workBuffer.pop_front();
|
|
}
|
|
}
|
|
|
|
void Instance::JSCallInvoker::invokeSync(std::function<void()> &&work) {
|
|
// TODO: Replace JS Callinvoker with RuntimeExecutor.
|
|
throw std::runtime_error(
|
|
"Synchronous native -> JS calls are currently not supported.");
|
|
}
|
|
|
|
void Instance::JSCallInvoker::invokeAsync(std::function<void()> &&work) {
|
|
std::lock_guard<std::mutex> guard(m_mutex);
|
|
|
|
/**
|
|
* Why is is necessary to queue up async work?
|
|
*
|
|
* 1. TurboModuleManager must be created synchronously after the Instance,
|
|
* before we load the source code. This is when the NativeModule system
|
|
* is initialized. RCTDevLoadingView shows bundle download progress.
|
|
* 2. TurboModuleManager requires a JS CallInvoker.
|
|
* 3. The JS CallInvoker requires the NativeToJsBridge, which is created on
|
|
* the JS thread in Instance::initializeBridge.
|
|
*
|
|
* Therefore, although we don't call invokeAsync before the JS bundle is
|
|
* executed, this buffering is implemented anyways to ensure that work
|
|
* isn't discarded.
|
|
*/
|
|
if (m_shouldBuffer) {
|
|
m_workBuffer.push_back(std::move(work));
|
|
return;
|
|
}
|
|
|
|
scheduleAsync(std::move(work));
|
|
}
|
|
|
|
void Instance::JSCallInvoker::scheduleAsync(std::function<void()> &&work) {
|
|
if (auto strongNativeToJsBridge = m_nativeToJsBridge.lock()) {
|
|
strongNativeToJsBridge->runOnExecutorQueue(
|
|
[work = std::move(work)](JSExecutor *executor) {
|
|
work();
|
|
executor->flush();
|
|
});
|
|
}
|
|
}
|
|
|
|
} // namespace facebook::react
|