Files
react-native/packages/rn-tester/js/examples/Performance/performanceComparisonExamples/SetStateInWrongEffectExample2.js
T
Xin Chen a8962ce970 Refactor code structure to make it easier for adding new examples (#38799)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38799

Refactor the performance comparison examples to make it easier to add new ones.

Changelog:
[General][Internal] - Code refactor

Reviewed By: rshest

Differential Revision: D47857126

fbshipit-source-id: fc8ffbcc94a23b896a53f599161f3bf6e9c2eaad
2023-08-08 15:13:28 -07:00

63 lines
1.8 KiB
JavaScript

/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
* @oncall react_native
*/
'use strict';
import type {ItemDataType} from '../components/itemData';
import * as React from 'react';
import ItemList from '../components/ItemList';
import {LIST_1000_ITEMS} from '../components/itemData';
const {useState, useEffect} = React;
const ItemListMemo = React.memo(ItemList);
function BadExample(props: {listData: ItemDataType[], filteredText: string}) {
const {listData, filteredText} = props;
const [visibleListData, setVisibleListData] =
useState<ItemDataType[]>(listData);
useEffect(() => {
setVisibleListData(
listData.filter(item =>
item.name.toUpperCase().includes(filteredText.toUpperCase()),
),
);
}, [listData, filteredText]);
return <ItemListMemo data={visibleListData} />;
}
function GoodExample(props: {listData: ItemDataType[], filteredText: string}) {
const {listData, filteredText} = props;
const visibleListData = listData.filter(item =>
item.name.toUpperCase().includes(filteredText.toUpperCase()),
);
return <ItemListMemo data={visibleListData} />;
}
function SetStateInWrongEffectBadExample(): React.Node {
return <BadExample listData={LIST_1000_ITEMS} filteredText="f8" />;
}
function SetStateInWrongEffectGoodExample(): React.Node {
return <GoodExample listData={LIST_1000_ITEMS} filteredText="f8" />;
}
export default {
title: 'Re-render with unnecessary effect and state changes',
description:
'You may not need an effect in your component. State updates in unnecessary effects will trigger re-render that can be avoided.',
Bad: SetStateInWrongEffectBadExample,
Good: SetStateInWrongEffectGoodExample,
};