mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Nick Gerleman 6d8868b2d8 Minimize EditText Spans 1/9: Fix precedence (#36543 )

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36543

This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( https://github.com/facebook/react-native/issues/35936#issuecomment-1411437789) for greater context on the platform behavior.

We cache the backing EditText span on text change to later measure. To measure outside of a TextInput we need to restore any spans we removed. Spans may overlap, so base attributes should be behind everything else.

The logic here for dealing with precedence is incorrect, and we should instead accomplish this by twiddling with the `SPAN_PRIORITY` bits.

Changelog:
[Android][Fixed] - Minimize Spans 1/N: Fix precedence

Reviewed By: javache

Differential Revision: D44240779

fbshipit-source-id: f731b353587888faad946b8cf1e868095cdeced3

2023-04-11 15:56:09 +01:00

cmake-utils

Fixing failure building RN codegen CLI on Windows (#34791 )

2022-10-11 13:23:51 +01:00

hermes-engine

Use NMake generator for Hermes build on Windows (#34790 )

2022-10-11 13:24:05 +01:00

libs

Upgrade Android support library to version 28 in RN

2019-01-22 10:44:53 -08:00

src

Minimize EditText Spans 1/9: Fix precedence (#36543 )