mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47915 ## Purpose of this noop-ing If an fatal js error happens during js runtime init, the js thread continues executing and raises **yet another** fatal error. This noop-ing was an **attempt** to prevent that second inactionable fatal from happening: That fatal is usually inactionable. ## Problems with this noop-ing I don't think this is the right approach: There could be legitimate reasons to continue executing native -> js calls post first js fatal. I don't think it does *much*: it doesn't noop native -> js calls executed on the runtime scheduler, which should be most of them. ## Changes Instead of trying to prevent that fatal, just let it happen. Then, don't report the second fatal: D66193194 and D66392706. ## Safetly The production impact is negligible: This codepath is executed only after early js errors. There shouldn't be any in production right now. We've spent a lot of time making our javascript error handling pipeline's coverage compresive. So, after an early js fatal error happens, subsequent js fatals should get handled properly. Changelog: [Internal] Reviewed By: javache Differential Revision: D66394278 fbshipit-source-id: ef342fc2eba9ae9f27b15a0f412fb69bd92aed43