react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Alex Hunt 6f421230c1 Drop appId from /open-debugger calls, disable matching for modern targets (#47120 )

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/47120

Fixes no-op behaviour of the "Open DevTools" Dev Menu item (bug on `main` introduced with D63329456).

This was caused by a change to the `description` field contents in our CDP `/json/list` response, when under Fusebox. In the `/open-debugger` call from the Dev Menu, we were still using the older `appId` param.

This did not affect `j` to debug, which uses the `target` param.

{F1937186832}

Changes:

In short: Matching against the `description` string is now fully eliminated for modern debugger targets.

- Update native Dev Menu implementation to omit `appId` parameter (`device` param alone is sufficient and fully precise on these platforms).
- Update `/open-debugger` implementation to ignore the `appId` parameter for modern targets, and document this in the `dev-middleware` README.

Changelog: [Internal]

Reviewed By: robhogan

Differential Revision: D64597581

fbshipit-source-id: 46f536e7d0a4ececab0d52f4c0704e8698466cd0

2024-10-18 11:02:51 -07:00

__tests__

Drop appId from /open-debugger calls, disable matching for modern targets (#47120 )

2024-10-18 11:02:51 -07:00

inspector-proxy

Drop appId from /open-debugger calls, disable matching for modern targets (#47120 )

2024-10-18 11:02:51 -07:00

middleware

Drop appId from /open-debugger calls, disable matching for modern targets (#47120 )

2024-10-18 11:02:51 -07:00

types

add appId to Telemetry (#47099 )