Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
67e589ce06449f690017079dbbcf2a2a93eff239
react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog
T
History
Dulmandakh 243070afe2 DialogModule supports only FragmentActivity (#23365) 
Summary:
Now RN has only ReactActivity which extends AppCompatActivity, subclass of FragmentActivity, therefore no need to check if activity is FragmentActivity or not. This PR changes DialogModule to work only with FragmentActivity.

Also DialogFragment from Android is deprecated in API 28, and recommends to use DialogFragment from Support Library. Excerpt from DialogFragment documentation.

> **This class was deprecated in API level 28.**
> Use the Support Library DialogFragment for consistent behavior across all devices and access to Lifecycle.

**BREAKING CHANGE**: Brown field apps must extend FragmentActivity or its subclasses.

[Android] [Changed] - DialogModule supports only FragmentActivity
Pull Request resolved: https://github.com/facebook/react-native/pull/23365

Differential Revision: D14021986

Pulled By: cpojer

fbshipit-source-id: b0ede60ef19cec48111a12701659a8bc1f66c331
2019-04-26 02:46:24 -07:00
..
AlertFragment.java
DialogModule supports only FragmentActivity (#23365)
2019-04-26 02:46:24 -07:00
BUCK
Removing more unused libraries from the repo
2019-04-16 11:32:43 -07:00
DialogModule.java
DialogModule supports only FragmentActivity (#23365)
2019-04-26 02:46:24 -07:00