Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
65b7680720435c0d864df9c121c151b60bee08ad
react-native/packages
T
History
Nick GerlemanandFacebook GitHub Bot 65b7680720 Fix bad comparison in RCTScrollViewComponentView RTL (#39030) 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39030

D29164056 fixed `scrollTo` coordinate space in RTL, but D38499666 regressed it by adding a comparison before the RTL conversion happens.

This makes `scrollTo` no-op if we are scrolling from the beginning to the end of the list, since the end of the list is `x: 0` in cartesian coordinates, and the start of the list is `x: 0` in flow-relative coordinates.

Do coordinate conversion before the early exit check.

Changelog:
[iOS][Fixed] - Fix bad comparison in RCTScrollViewComponentView RTL

Reviewed By: rshest

Differential Revision: D48378414

fbshipit-source-id: 14b0b9bb3b22828c290bbbc93b907d8c0e264995
2023-08-16 16:35:52 -07:00
..
assets
Update Node.js to v18 in all RN packages (#37791)
2023-06-22 09:53:21 -07:00
babel-plugin-codegen
Update Node.js to v18 in all RN packages (#37791)
2023-06-22 09:53:21 -07:00
community-cli-plugin
Replace Metro stdout check with dep_graph_loaded event (#38960)
2023-08-15 02:33:22 -07:00
dev-middleware
Add auto-generation of TypeScript definitions on build (#38990)
2023-08-14 12:12:10 -07:00
eslint-config-react-native
JS: Upgrade to v8-compile-cache@^2.4.0 & eslint@^8.23.1 (#39012)
2023-08-15 15:49:33 -07:00
eslint-plugin-react-native
Update Node.js to v18 in all RN packages (#37791)
2023-06-22 09:53:21 -07:00
eslint-plugin-specs
Update Node.js to v18 in all RN packages (#37791)
2023-06-22 09:53:21 -07:00
hermes-inspector-msggen
Update Node.js to v18 in all RN packages (#37791)
2023-06-22 09:53:21 -07:00
metro-config
Upgrade CLI and Metro, update status check refs (#38988)
2023-08-15 02:33:22 -07:00
normalize-color
Update Node.js to v18 in all RN packages (#37791)
2023-06-22 09:53:21 -07:00
polyfills
Update Node.js to v18 in all RN packages (#37791)
2023-06-22 09:53:21 -07:00
react-native
Fix bad comparison in RCTScrollViewComponentView RTL (#39030)
2023-08-16 16:35:52 -07:00
react-native-babel-preset
Add @react-native/babel-plugin-codegen to @react-native/babel-preset (#38227)
2023-08-01 07:49:23 -07:00
react-native-babel-transformer
Remove unused inlineRequires params from BabelTransformer API (#38771)
2023-08-07 09:17:43 -07:00
react-native-bots
Cleanup the commitlies code (#38889)
2023-08-09 09:23:14 -07:00
react-native-codegen
add emitBuildEventSchema to parser commons (#38810)
2023-08-08 11:52:26 -07:00
react-native-codegen-typescript-test
Update Node.js to v18 in all RN packages (#37791)
2023-06-22 09:53:21 -07:00
react-native-gradle-plugin
Introduce react.internal.useHermesNightly (#38886)
2023-08-14 00:45:07 -07:00
rn-tester
Update example description to help understand them better (#38797)
2023-08-16 13:27:40 -07:00
rn-tester-e2e
Bump Android compile-sdk to 34 (#38987)
2023-08-15 03:13:35 -07:00
typescript-config
Better TypeScript support for package.json exports field (#37377)
2023-05-13 09:38:17 -07:00
virtualized-lists
ListMetricAggregator UTs - cell offset APIs (#38732)
2023-08-15 21:56:25 -07:00