mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Nicola Corti ccc50ddd2d Fabric Interop - Properly dispatch integer commands (#38527 )

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38527

This fixes a bug that got reported for the Fabric Interop for Android with Command dispatching.
(See https://github.com/terrylinla/react-native-sketch-canvas/issues/236)

The problem is that libraries that were receiving commands as ints with:
```
public void receiveCommand(
      int surfaceId, int reactTag, int commandId, Nullable ReadableArray commandArgs) {
```

would not receive command with the Fabric Interop for Android.

The problem is that with Fabric, events are dispatched as string always.
cipolleschi took care of this for iOS, but we realized that the Android part was missing. I'm adding it here.

The logic is, if the event is dispatched as a string that represents a number (say `"42"`) and the user has Fabric Interop enabled, then we dispatch the event as `int` (so libraries will keep on working).

Changelog:
[Android] [Fixed] - Fabric Interop - Properly dispatch integer commands

Reviewed By: cipolleschi

Differential Revision: D47600094

fbshipit-source-id: c35f0509e6c6c0cddc7090a069882f92dd95532e

2023-07-21 10:17:31 -07:00

cmake-utils

Expose react_utils via prefab to fix broken test_android (#37965 )

2023-06-19 10:46:51 -07:00

external-artifacts

| RN Monorepo | Migrate to package (#36434 )

2023-03-17 05:03:25 -07:00

flipper-integration

Bump Flipper to 0.201.0 (#38260 )

2023-07-13 17:57:23 -07:00

hermes-engine

Better Incremental build for :ReactAndroid:hermes-engine (#38497 )