mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
David Vacca
65975dd28d
Summary: This diff changes the type of the SwipeRefreshLayoutManager.size prop from Int to String in Fabric. The current implementation of this prop allows JS developers to use "int" type when fabric is enables and "int or string" types when using Fabric is disabled. Since long term we want to only support "string" type for this prop, I'm changing the type of the prop to be String. After my diff Fabric will start supporting only "string" types, non fabric screens will keep supporting "int or string" values. **Will this break production?** No, because there are no usages of RefreshControl.Size prop in fbsource **What about if someone start using this prop next week?** IMO It's very unlikely because of the nature of this prop, I will be monitoring next week and if there's an usage it will be detected by flow when trying to land D25933457. Changelog: [Android][Changed] - RefreshControl.size prop changed its type to string, the valid values are: 'default' and 'large' Reviewed By: JoshuaGross Differential Revision: D25933458 fbshipit-source-id: 55067d7405b063f1e8d9bb7a5fd7731f5f168960
79 lines
1.9 KiB
JavaScript
79 lines
1.9 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @flow strict-local
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
import * as React from 'react';
|
|
|
|
import codegenNativeCommands from 'react-native/Libraries/Utilities/codegenNativeCommands';
|
|
import codegenNativeComponent from '../../Utilities/codegenNativeComponent';
|
|
import type {HostComponent} from '../../Renderer/shims/ReactNativeTypes';
|
|
|
|
import type {
|
|
DirectEventHandler,
|
|
Float,
|
|
Int32,
|
|
WithDefault,
|
|
} from '../../Types/CodegenTypes';
|
|
import type {ColorValue} from '../../StyleSheet/StyleSheet';
|
|
import type {ViewProps} from '../View/ViewPropTypes';
|
|
|
|
type NativeProps = $ReadOnly<{|
|
|
...ViewProps,
|
|
|
|
/**
|
|
* Whether the pull to refresh functionality is enabled.
|
|
*/
|
|
enabled?: WithDefault<boolean, true>,
|
|
/**
|
|
* The colors (at least one) that will be used to draw the refresh indicator.
|
|
*/
|
|
colors?: ?$ReadOnlyArray<ColorValue>,
|
|
/**
|
|
* The background color of the refresh indicator.
|
|
*/
|
|
progressBackgroundColor?: ?ColorValue,
|
|
/**
|
|
* Size of the refresh indicator, see RefreshControl.SIZE.
|
|
*/
|
|
size?: WithDefault<'default' | 'large', 'default'>,
|
|
/**
|
|
* Progress view top offset
|
|
*/
|
|
progressViewOffset?: WithDefault<Float, 0>,
|
|
|
|
/**
|
|
* Called when the view starts refreshing.
|
|
*/
|
|
onRefresh?: ?DirectEventHandler<null>,
|
|
|
|
/**
|
|
* Whether the view should be indicating an active refresh.
|
|
*/
|
|
refreshing: boolean,
|
|
|}>;
|
|
|
|
type NativeType = HostComponent<NativeProps>;
|
|
|
|
interface NativeCommands {
|
|
+setNativeRefreshing: (
|
|
viewRef: React.ElementRef<NativeType>,
|
|
value: boolean,
|
|
) => void;
|
|
}
|
|
|
|
export const Commands: NativeCommands = codegenNativeCommands<NativeCommands>({
|
|
supportedCommands: ['setNativeRefreshing'],
|
|
});
|
|
|
|
export default (codegenNativeComponent<NativeProps>(
|
|
'AndroidSwipeRefreshLayout',
|
|
): NativeType);
|