mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Gabriel Donadel
84144272ba
Summary: There is a problem in the way that we check if Fabric is enabled inside `react_native_post_install`. https://github.com/facebook/react-native/blob/899e7cdb55197fc17a96a93af4f8bcc7519553c2/packages/react-native/scripts/react_native_pods.rb#L239 We're determining if fabric is enabled by checking if the `React-Fabric pod `is present, but since we always call `setup_fabric!(:react_native_path => prefix)` (https://github.com/facebook/react-native/pull/39057) inside `use_react_native` the `React-Fabric` pod is always present causing the `-DRN_FABRIC_ENABLED` flag to always be added to `project.pbxproj` even if the new arch is disabled. [IOS] [FIXED] - Fix ios pod post_install logic for detecting if fabric is enabled Pull Request resolved: https://github.com/facebook/react-native/pull/41284 Test Plan: Run `use_react_native!(fabric => false)` should not add the `-DRN_FABRIC_ENABLED` flag to `project.pbxproj` Reviewed By: fkgozali Differential Revision: D50896487 Pulled By: cipolleschi fbshipit-source-id: 78154407ce52b09fd3a317b7dc64bd4bba56363e