mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin Shergin
11c9f480af
Summary: This diff makes the parsing *Props object with sub-props with duplicating names deterministic: only the first one will be assigned. Before this change, the order was not guaranteed because `qsort` sorting algorithm is not stable and because binary search that we use to search in the sorted array does not handle duplicates deterministically. The behavior when the only sub-prop (the first one) is being assigned actually desirable feature that exists on purpose. There are places where it's desired behavior (like TextInputProps) and in cases where it's not desired (we don't really have those), it's easy to "fix" implementing the custom constructor. Changelog: [Internal] Fabric-specific internal change. Reviewed By: JoshuaGross Differential Revision: D18607657 fbshipit-source-id: aa53a320e6a48877a0dd1b9351dfcc8a9f419b38
65 lines
1.7 KiB
C++
65 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <better/small_vector.h>
|
|
|
|
#include <react/core/RawPropsKey.h>
|
|
#include <react/core/RawPropsPrimitives.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
/*
|
|
* A map especially optimized to hold `{name: index}` relations.
|
|
* The implementation is conceptually similar to a classic hash map with a hash
|
|
* function that returns the length of the string.
|
|
* The map is optimized for reads only (the map must be reindexed before a bunch
|
|
* of reads).
|
|
*/
|
|
class RawPropsKeyMap final {
|
|
public:
|
|
/*
|
|
* Stores `value` with by given `key`.
|
|
*/
|
|
void insert(RawPropsKey const &key, RawPropsValueIndex value) noexcept;
|
|
|
|
/*
|
|
* Reindexes the stored data.
|
|
* Must be called before `at` (after calling a bunch of `add`s).
|
|
*/
|
|
void reindex() noexcept;
|
|
|
|
/*
|
|
* Finds and returns the `value` (some index) by given `key`.
|
|
* Returns `kRawPropsValueIndexEmpty` if the value wan't found.
|
|
*/
|
|
RawPropsValueIndex at(
|
|
char const *name,
|
|
RawPropsPropNameLength length) noexcept;
|
|
|
|
private:
|
|
struct Item {
|
|
RawPropsValueIndex value;
|
|
RawPropsPropNameLength length;
|
|
char name[kPropNameLengthHardCap];
|
|
};
|
|
|
|
static bool shouldFirstOneBeBeforeSecondOne(
|
|
Item const &lhs,
|
|
Item const &rhs) noexcept;
|
|
static bool hasSameName(Item const &lhs, Item const &rhs) noexcept;
|
|
|
|
better::small_vector<Item, kNumberOfExplicitlySpecifedPropsSoftCap> items_{};
|
|
better::small_vector<RawPropsPropNameLength, kPropNameLengthHardCap>
|
|
buckets_{};
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|