mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Héctor Ramos
a68c418082
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/35038 React-jsi provides JSI to allow React Native to interface with JavaScriptCore. The hermes-engine Pod provides a second copy of JSI, as Hermes is built and linked statically with JSI. This second copy of JSI would lead to an [ODR Violation](https://en.cppreference.com/w/cpp/language/definition). To resolve this, when Hermes is enabled: - React-hermes and hermes-engine are installed. - React-jsc is not installed. - React-jsi continues to be installed. - React-jsi will not build JSI. - React-jsi will declare a dependency on hermes-engine. The result is that the JSI dependency for React Native is satisfied by hermes-engine, and there is no duplicate JSI library in the project. When Hermes is disabled: - React-jsi and React-jsc are installed. - React-hermes and hermes-engine are not installed. - React-jsi will build JSI. Changelog: [iOS][Changed] Resolve JSI ODR violation, make hermes-engine the JSI provider when Hermes is enabled Reviewed By: cipolleschi Differential Revision: D40334913 fbshipit-source-id: 409407a193a35cbd21b0e8778537b3627e4c54a2
48 lines
1.6 KiB
Ruby
48 lines
1.6 KiB
Ruby
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
||
#
|
||
# This source code is licensed under the MIT license found in the
|
||
# LICENSE file in the root directory of this source tree.
|
||
|
||
require "json"
|
||
|
||
js_engine = ENV['USE_HERMES'] == "0" ?
|
||
:jsc :
|
||
:hermes
|
||
|
||
package = JSON.parse(File.read(File.join(__dir__, "..", "..", "package.json")))
|
||
version = package['version']
|
||
|
||
source = { :git => 'https://github.com/facebook/react-native.git' }
|
||
if version == '1000.0.0'
|
||
# This is an unpublished version, use the latest commit hash of the react-native repo, which we’re presumably in.
|
||
source[:commit] = `git rev-parse HEAD`.strip if system("git rev-parse --git-dir > /dev/null 2>&1")
|
||
else
|
||
source[:tag] = "v#{version}"
|
||
end
|
||
|
||
Pod::Spec.new do |s|
|
||
s.name = "React-jsi"
|
||
s.version = version
|
||
s.summary = "JavaScript Interface layer for React Native"
|
||
s.homepage = "https://reactnative.dev/"
|
||
s.license = package["license"]
|
||
s.author = "Facebook, Inc. and its affiliates"
|
||
s.platforms = { :ios => "12.4" }
|
||
s.source = source
|
||
|
||
if js_engine == :jsc
|
||
s.source_files = "**/*.{cpp,h}"
|
||
s.exclude_files = [
|
||
"jsi/JSIDynamic.{h,cpp}",
|
||
"jsi/jsilib-posix.cpp",
|
||
"jsi/jsilib-windows.cpp",
|
||
"**/test/*"
|
||
]
|
||
s.header_dir = "jsi"
|
||
elsif js_engine == :hermes
|
||
# JSI is provided by hermes-engine when Hermes is enabled
|
||
s.source_files = ""
|
||
s.dependency "hermes-engine"
|
||
end
|
||
end
|