Files
react-native/ReactCommon/fabric/core/state/State.cpp
T
Valentin Shergin 91540d74b1 Fabric: Fixing a retain cycle in between State and ShadowNodeFamily
Summary:
This change removes the concept of `StateTarget`, replacing its role with `ShadowNodeFamily`.
When `StateTarget` was built, we didn't have a concept of `Family`, and when we added it we introduced a retain-cycle: ShadowNode -> Family -> StateTarget -> ShadowNode. This diff fixes that.

This change does not change conceptually how the state behaves, it just adjusts internal machinery.

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: sammy-SC

Differential Revision: D19799013

fbshipit-source-id: c1360bfbf6b8ac34e2a856a40047eafeb50ed070
2020-02-09 22:28:40 -08:00

41 lines
946 B
C++

/*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include "State.h"
#include <react/core/ShadowNode.h>
#include <react/core/ShadowNodeFragment.h>
#include <react/core/State.h>
#include <react/core/StateData.h>
namespace facebook {
namespace react {
State::State(StateData::Shared const &data, State const &state)
: family_(state.family_), data_(data), revision_(state.revision_ + 1){};
State::State(
StateData::Shared const &data,
ShadowNodeFamily::Shared const &family)
: family_(family), data_(data), revision_{1} {};
State::Shared State::getMostRecentState() const {
auto family = family_.lock();
if (!family) {
return {};
}
return family->getMostRecentState();
}
size_t State::getRevision() const {
return revision_;
}
} // namespace react
} // namespace facebook