mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Spencer Ahrens
7b5277bb75
Summary: It works great on iOS, and mostly works on Android, and is now OTA'able as part of the screen config! Haven't done template view yet. One remaining issue: Layout is borked on Android. I'm guessing the issue has to do with the timing of setting the constraints in `updateRootLayoutSpecs` and calling `mBinding.startSurface` which actually builds the shadow tree. If I try to call `updateRootLayoutSpecs` earlier, it just crashes immediately. Here's the layout it spits out, which clearly has -440 for the x of 420006, which is the RCTText component, causing it to get cut off on the left of the screen: ``` updateLayoutMountItem for reactTag: 420006 x: -440, y: -13, width: 931, height: 78 updateLayoutMountItem for reactTag: 420010 x: 26, y: 79, width: 0, height: 1651 updateLayoutMountItem for reactTag: 420012 x: 0, y: 26, width: 0, height: 158 updateLayoutMountItem for reactTag: 420016 x: 0, y: 210, width: 454, height: 454 updateLayoutMountItem for reactTag: 420018 x: 454, y: 210, width: 455, height: 454 updateLayoutMountItem for reactTag: 420022 x: 0, y: 690, width: 454, height: 454 updateLayoutMountItem for reactTag: 420024 x: 454, y: 690, width: 455, height: 454 updateLayoutMountItem for reactTag: 420028 x: 0, y: 1171, width: 454, height: 454 updateLayoutMountItem for reactTag: 420030 x: 454, y: 1171, width: 455, height: 454 updateLayoutMountItem for reactTag: 420032 x: 0, y: 1651, width: 0, height: 0 ``` Reviewed By: mdvacca Differential Revision: D12813192 fbshipit-source-id: 450d646af4883ff25184141721351da67b091b7c
49 lines
1.5 KiB
Java
49 lines
1.5 KiB
Java
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
package com.facebook.react.bridge;
|
|
|
|
import com.facebook.react.bridge.WritableMap;
|
|
import com.facebook.react.uimanager.common.MeasureSpecProvider;
|
|
import com.facebook.react.uimanager.common.SizeMonitoringFrameLayout;
|
|
|
|
import javax.annotation.Nullable;
|
|
|
|
public interface UIManager extends JSIModule, PerformanceCounter {
|
|
|
|
/**
|
|
* Registers a new root view.
|
|
*/
|
|
<T extends SizeMonitoringFrameLayout & MeasureSpecProvider> int addRootView(final T rootView, WritableMap initialProps, @Nullable String initialUITemplate);
|
|
|
|
/**
|
|
* Unregisters a new root view.
|
|
*/
|
|
void removeRootView(int reactRootTag);
|
|
|
|
/**
|
|
* Updates the layout specs of the RootShadowNode based on the Measure specs received by
|
|
* parameters.
|
|
*/
|
|
void updateRootLayoutSpecs(int rootTag, int widthMeasureSpec, int heightMeasureSpec);
|
|
|
|
/**
|
|
* Dispatches the commandId received by parameter to the view associated with the reactTag.
|
|
* The command will be processed in the UIThread.
|
|
*
|
|
* @param reactTag {@link int} that identifies the view that will receive this command
|
|
* @param commandId {@link int} command id
|
|
* @param commandArgs {@link ReadableArray} parameters associated with the command
|
|
*/
|
|
void dispatchCommand(int reactTag, int commandId, @Nullable ReadableArray commandArgs);
|
|
|
|
void setJSResponder(int reactTag, boolean blockNativeResponder);
|
|
|
|
void clearJSResponder();
|
|
|
|
}
|