mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel Susla
5fa6c5a941
Summary: changelog: [internal] You can read more about this rule on https://clang.llvm.org/extra/clang-tidy/checks/modernize-pass-by-value.html # Isn't it wasteful to copy? Isn't reference more efficient? This rule of thumb is no longer true since C++11 with move semantics. Let's look at some examples. # Option one ``` class TextHolder { public: TextBox(std::string const &text) : text_(text) {} private: std::string text_; }; ``` By using reference here, we prevent the caller from using rvalue to and avoiding copy. Regardless of what the caller passes in, copy always happens. # Option two ``` class TextHolder { public: TextBox(std::string const &text) : text_(text) {} TextBox(std::string &&text) : text_(std::move(text)) {} private: std::string text_; }; ``` Here, we provide two constructors, one for const reference and one for rvalue reference. This gives the caller option to avoid copy. But now we have two constructors, which is not ideal. # Option three (what we do in this diff) ``` class TextHolder { public: TextBox(std::string text) : text_(std::move(text)) {} private: std::string text_; }; ``` Here, the caller has option to avoid copy and we only have single constructor. Reviewed By: fkgozali, JoshuaGross Differential Revision: D33276841 fbshipit-source-id: 619d5123d2e28937b22874650366629f24f20a63
166 lines
5.3 KiB
C++
166 lines
5.3 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "TransactionTelemetry.h"
|
|
|
|
#include <react/debug/react_native_assert.h>
|
|
|
|
#include <utility>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
thread_local TransactionTelemetry *threadLocalTransactionTelemetry = nullptr;
|
|
|
|
TransactionTelemetry::TransactionTelemetry()
|
|
: TransactionTelemetry(telemetryTimePointNow) {}
|
|
|
|
TransactionTelemetry::TransactionTelemetry(
|
|
std::function<TelemetryTimePoint()> now)
|
|
: now_{std::move(now)} {}
|
|
|
|
TransactionTelemetry *TransactionTelemetry::threadLocalTelemetry() {
|
|
return threadLocalTransactionTelemetry;
|
|
}
|
|
|
|
void TransactionTelemetry::setAsThreadLocal() {
|
|
threadLocalTransactionTelemetry = this;
|
|
}
|
|
|
|
void TransactionTelemetry::unsetAsThreadLocal() {
|
|
threadLocalTransactionTelemetry = nullptr;
|
|
}
|
|
|
|
void TransactionTelemetry::willCommit() {
|
|
react_native_assert(commitStartTime_ == kTelemetryUndefinedTimePoint);
|
|
react_native_assert(commitEndTime_ == kTelemetryUndefinedTimePoint);
|
|
commitStartTime_ = now_();
|
|
}
|
|
|
|
void TransactionTelemetry::didCommit() {
|
|
react_native_assert(commitStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(commitEndTime_ == kTelemetryUndefinedTimePoint);
|
|
commitEndTime_ = now_();
|
|
}
|
|
|
|
void TransactionTelemetry::willDiff() {
|
|
react_native_assert(diffStartTime_ == kTelemetryUndefinedTimePoint);
|
|
react_native_assert(diffEndTime_ == kTelemetryUndefinedTimePoint);
|
|
diffStartTime_ = now_();
|
|
}
|
|
|
|
void TransactionTelemetry::didDiff() {
|
|
react_native_assert(diffStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(diffEndTime_ == kTelemetryUndefinedTimePoint);
|
|
diffEndTime_ = now_();
|
|
}
|
|
|
|
void TransactionTelemetry::willLayout() {
|
|
react_native_assert(layoutStartTime_ == kTelemetryUndefinedTimePoint);
|
|
react_native_assert(layoutEndTime_ == kTelemetryUndefinedTimePoint);
|
|
layoutStartTime_ = now_();
|
|
}
|
|
|
|
void TransactionTelemetry::willMeasureText() {
|
|
react_native_assert(
|
|
lastTextMeasureStartTime_ == kTelemetryUndefinedTimePoint);
|
|
lastTextMeasureStartTime_ = now_();
|
|
}
|
|
|
|
void TransactionTelemetry::didMeasureText() {
|
|
numberOfTextMeasurements_++;
|
|
react_native_assert(
|
|
lastTextMeasureStartTime_ != kTelemetryUndefinedTimePoint);
|
|
textMeasureTime_ += now_() - lastTextMeasureStartTime_;
|
|
lastTextMeasureStartTime_ = kTelemetryUndefinedTimePoint;
|
|
}
|
|
|
|
void TransactionTelemetry::didLayout() {
|
|
react_native_assert(layoutStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(layoutEndTime_ == kTelemetryUndefinedTimePoint);
|
|
layoutEndTime_ = now_();
|
|
}
|
|
|
|
void TransactionTelemetry::willMount() {
|
|
react_native_assert(mountStartTime_ == kTelemetryUndefinedTimePoint);
|
|
react_native_assert(mountEndTime_ == kTelemetryUndefinedTimePoint);
|
|
mountStartTime_ = now_();
|
|
}
|
|
|
|
void TransactionTelemetry::didMount() {
|
|
react_native_assert(mountStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(mountEndTime_ == kTelemetryUndefinedTimePoint);
|
|
mountEndTime_ = now_();
|
|
}
|
|
|
|
void TransactionTelemetry::setRevisionNumber(int revisionNumber) {
|
|
revisionNumber_ = revisionNumber;
|
|
}
|
|
|
|
TelemetryTimePoint TransactionTelemetry::getDiffStartTime() const {
|
|
react_native_assert(diffStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(diffEndTime_ != kTelemetryUndefinedTimePoint);
|
|
return diffStartTime_;
|
|
}
|
|
|
|
TelemetryTimePoint TransactionTelemetry::getDiffEndTime() const {
|
|
react_native_assert(diffStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(diffEndTime_ != kTelemetryUndefinedTimePoint);
|
|
return diffEndTime_;
|
|
}
|
|
|
|
TelemetryTimePoint TransactionTelemetry::getCommitStartTime() const {
|
|
react_native_assert(commitStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(commitEndTime_ != kTelemetryUndefinedTimePoint);
|
|
return commitStartTime_;
|
|
}
|
|
|
|
TelemetryTimePoint TransactionTelemetry::getCommitEndTime() const {
|
|
react_native_assert(commitStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(commitEndTime_ != kTelemetryUndefinedTimePoint);
|
|
return commitEndTime_;
|
|
}
|
|
|
|
TelemetryTimePoint TransactionTelemetry::getLayoutStartTime() const {
|
|
react_native_assert(layoutStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(layoutEndTime_ != kTelemetryUndefinedTimePoint);
|
|
return layoutStartTime_;
|
|
}
|
|
|
|
TelemetryTimePoint TransactionTelemetry::getLayoutEndTime() const {
|
|
react_native_assert(layoutStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(layoutEndTime_ != kTelemetryUndefinedTimePoint);
|
|
return layoutEndTime_;
|
|
}
|
|
|
|
TelemetryTimePoint TransactionTelemetry::getMountStartTime() const {
|
|
react_native_assert(mountStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(mountEndTime_ != kTelemetryUndefinedTimePoint);
|
|
return mountStartTime_;
|
|
}
|
|
|
|
TelemetryTimePoint TransactionTelemetry::getMountEndTime() const {
|
|
react_native_assert(mountStartTime_ != kTelemetryUndefinedTimePoint);
|
|
react_native_assert(mountEndTime_ != kTelemetryUndefinedTimePoint);
|
|
return mountEndTime_;
|
|
}
|
|
|
|
TelemetryDuration TransactionTelemetry::getTextMeasureTime() const {
|
|
return textMeasureTime_;
|
|
}
|
|
|
|
int TransactionTelemetry::getNumberOfTextMeasurements() const {
|
|
return numberOfTextMeasurements_;
|
|
}
|
|
|
|
int TransactionTelemetry::getRevisionNumber() const {
|
|
return revisionNumber_;
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|