mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin Shergin
5dc6eded1b
Summary: Apparently, `std::this_thread::sleep_for` uses a different clock to measure time which causes ofter misalignment with the clock which Telemery uses which makes the test flaky. Using the same clock should fix it. Changelog: [Internal] Fabric-specific internal change. Reviewed By: JoshuaGross Differential Revision: D21116058 fbshipit-source-id: 52dde2e325776d365431a2a957dcc12dfe53f890
112 lines
3.0 KiB
C++
112 lines
3.0 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <chrono>
|
|
#include <thread>
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <react/mounting/MountingTelemetry.h>
|
|
#include <react/utils/Telemetry.h>
|
|
|
|
using namespace facebook::react;
|
|
|
|
#define EXPECT_EQ_WITH_THRESHOLD(a, b, threshold) \
|
|
EXPECT_TRUE((a >= b - threshold) && (a <= b + threshold))
|
|
|
|
template <typename ClockT>
|
|
void sleep(double durationInSeconds) {
|
|
auto timepoint = ClockT::now() +
|
|
std::chrono::milliseconds((long long)(durationInSeconds * 1000));
|
|
while (ClockT::now() < timepoint) {
|
|
}
|
|
}
|
|
|
|
TEST(MountingTelemetryTest, timepoints) {
|
|
auto threshold = int64_t{10};
|
|
|
|
auto timepointA = telemetryTimePointNow();
|
|
sleep<TelemetryClock>(0.1);
|
|
auto timepointB = telemetryTimePointNow();
|
|
|
|
auto duration = telemetryDurationToMilliseconds(timepointB - timepointA);
|
|
|
|
EXPECT_EQ_WITH_THRESHOLD(duration, 100, threshold);
|
|
}
|
|
|
|
TEST(MountingTelemetryTest, normalUseCase) {
|
|
auto threshold = int64_t{10};
|
|
auto telemetry = MountingTelemetry{};
|
|
|
|
telemetry.willCommit();
|
|
sleep<TelemetryClock>(0.1);
|
|
telemetry.willLayout();
|
|
sleep<TelemetryClock>(0.2);
|
|
telemetry.didLayout();
|
|
sleep<TelemetryClock>(0.1);
|
|
telemetry.didCommit();
|
|
|
|
sleep<TelemetryClock>(0.3);
|
|
|
|
telemetry.willMount();
|
|
sleep<TelemetryClock>(0.1);
|
|
telemetry.didMount();
|
|
|
|
auto commitDuration = telemetryDurationToMilliseconds(
|
|
telemetry.getCommitEndTime() - telemetry.getCommitStartTime());
|
|
auto layoutDuration = telemetryDurationToMilliseconds(
|
|
telemetry.getLayoutEndTime() - telemetry.getLayoutStartTime());
|
|
auto mountDuration = telemetryDurationToMilliseconds(
|
|
telemetry.getMountEndTime() - telemetry.getMountStartTime());
|
|
|
|
EXPECT_EQ_WITH_THRESHOLD(commitDuration, 400, threshold);
|
|
EXPECT_EQ_WITH_THRESHOLD(layoutDuration, 200, threshold);
|
|
EXPECT_EQ_WITH_THRESHOLD(mountDuration, 100, threshold);
|
|
}
|
|
|
|
TEST(MountingTelemetryTest, abnormalUseCases) {
|
|
// Calling `did` before `will` should crash.
|
|
EXPECT_DEATH_IF_SUPPORTED(
|
|
{
|
|
auto telemetry = MountingTelemetry{};
|
|
telemetry.didDiff();
|
|
},
|
|
"diffStartTime_");
|
|
|
|
EXPECT_DEATH_IF_SUPPORTED(
|
|
{
|
|
auto telemetry = MountingTelemetry{};
|
|
telemetry.didCommit();
|
|
},
|
|
"commitStartTime_");
|
|
|
|
EXPECT_DEATH_IF_SUPPORTED(
|
|
{
|
|
auto telemetry = MountingTelemetry{};
|
|
telemetry.didMount();
|
|
},
|
|
"mountStartTime_");
|
|
|
|
// Getting `start` *or* `end` timepoints before a pair of `will` and `did`
|
|
// should crash.
|
|
EXPECT_DEATH_IF_SUPPORTED(
|
|
{
|
|
auto telemetry = MountingTelemetry{};
|
|
telemetry.willCommit();
|
|
telemetry.getCommitStartTime();
|
|
},
|
|
"commitEndTime_");
|
|
|
|
EXPECT_DEATH_IF_SUPPORTED(
|
|
{
|
|
auto telemetry = MountingTelemetry{};
|
|
telemetry.willCommit();
|
|
telemetry.getCommitEndTime();
|
|
},
|
|
"commitEndTime_");
|
|
}
|