mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Rick Hanlon
e0797d0e03
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48783 ## Overview This is the final boss of the new owner stacks feature. With owner stacks, we don't need to parse message strings to find the component stack for logbox. Instead, we can access the component stack directly with `captureOwnerStack`. This means we don't need to install the LogBox console.error patch and can greatly simplify the process of handling errors and make it more reliable. To do this, we rely only on adding LogBox to the ExceptionManager: - `reactConsoleErrorHandler` -> `LogBox.addConsoleLog` - `reportException` -> `LogBox.addException` Changelog: [General][Fixed] - Remove LogBox patch, de-duplicating errors ## Benefits As a side effect, this removes a lot of duplicate errors. For example, currently if a component throws, you get 2 errors: {F1974436906} After this, there's just the one you expect: {F1974436908} ## Followups After this lands and doesn't need reverted for some reason, we can delete a ton of code from logbox for finding and detecting stacks from errors. Reviewed By: javache Differential Revision: D68380668 fbshipit-source-id: 68112f1e3992fada4d6aaffdf9bd618ce1834f7b