mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
c11785b90d
Summary: Currently, we build Hermes by specifying the Cmake flag `-B ./hermes`. That means that the output out the build is going to be placed along side the source code. This is fine, as long as the user doesn't use the `REACT_NATIVE_OVERRIDE_HERMES_DIR`, which is used inside the Hermes CI. In that case, the source location of Hermes can be changed, leading to scenarios where `hermesc` can't be found. Here I'm changing the flag to be `-B $buildDir/hermes`. Therefore the build output will always be located within the `./ReactAndroid/hermes-engine/build` folder. This is a more robust solution as the build output will be encapsulated within the `build/` folder. Changelog:i [Internal] [Changed] - Update the hermesc output to be inside the $buildDir Reviewed By: cipolleschi Differential Revision: D35964402 fbshipit-source-id: aa7e0775b282897d5a99c1c46265884d19c5f289