mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
kunal.chavhan
18d6028ff9
Summary: Fixes: https://github.com/facebook/react-native/issues/43413 This pull request addresses an issue on Android where the text selection was not working when both `selectTextOnFocus` and `autoFocus` were set to true on TextInput. `ReactTextInputManager` was calling `setSelectAllOnFocus` on `ReactEditText` before its onLayout is called causing text selection to not work on auto focus. Changes Made - Added logic to wait for the ReactEditText view's layout to be drawn before attempting to select the text. On the first layout pass, the code now explicitly calls selectAll() to select the text. - Implemented a check to ensure selectAll() is only called during the first layout pass, avoiding unnecessary calls on subsequent layout passes. Impact This change ensures that text selection is properly triggered when selectTextOnFocus and autoFocus are both enabled, improving the user experience and making text input behavior consistent and reliable. ## Changelog: [ANDROID] [FIXED]: fixed select text on auto focus for TextInput <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: https://github.com/facebook/react-native/pull/45004 Test Plan: | Before | After | |--------|--------| |  |  | Reviewed By: javache Differential Revision: D59448600 Pulled By: cortinico fbshipit-source-id: 8a594d3193f227ba2d64b808d905bab8b3d24e9b