Files
react-native/packages
Michał Mąka 565e06f8d0 On setting the same state for ShadowNodeFamily, don't mark it as obsolete (#39095)
Summary:
During investigation of impact of PR https://github.com/facebook/react-native/pull/38706 on `reanimated` I found out that when:
- state reconciliation is turned on
- `progressState` in `ShadowTree::tryCommit` quite often returns a new pointer to updated shadow tree
- above happened due to `newState->getMostRecentStateIfObsolete()` returning precisely the same ptr as `newState` in `progressState`
- this is caused by calling `ShadowNodeFamily::setMostRecentState` with the same state as currently held and marking those states as obsolete

This PR adds additional check whether `ShadowNodeFamily::setMostRecentState` is called with the same `state` as currently set and skips setting obsolete flag if that happens.

## Changelog:

[INTERNAL][FIXED] Setting the same most recent state for ShadowNodeFamily, doesn't mark it as obsolete

Pull Request resolved: https://github.com/facebook/react-native/pull/39095

Test Plan: None

Reviewed By: cipolleschi

Differential Revision: D48526395

Pulled By: sammy-SC

fbshipit-source-id: f77cea2364611a42a3363285b4732f33aae8a0a7
2023-08-22 08:50:47 -07:00
..