mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel SuslaandFacebook GitHub Bot
41c788a2b4
Summary: Changelog: [internal] Problem: `props.transform` gets out of sync with `self.layer.transform`. To avoid writing out value of transform matrix, in the follow example I will only consider identity matrix and non-identity matrix. It is sufficient to demonstrate the point. 1. View is reused with transform being something besides identity. This causes `props.transform` and `self.layer.transform` to be non-identity. 2. View is taken from pool and animated with transform set to non-identity. 3. React JS props arrive and set `view.props` to identity but `self.layer.transform` stays unchanged because it is managed by native animation. This is the point where `props.transform` and `self.layer.transform` get out of sync. 4. Native animation wants to set transform to identity to finish the animation. But inside `[RCTViewComponentView updateProps:oldProps:]` `self.layer.transform` does not get set because current `view.props` is already identity. Solution: After native animation layer calls `[RCTViewComponentView updateProps:oldProps:]`, verify that values were set. If they weren't, set them directly without depending on `[RCTViewComponentView updateProps:oldProps:]`. Reviewed By: JoshuaGross Differential Revision: D24538442 fbshipit-source-id: ba8c59c5c9bb751306118bd1c7f0ccd9d0fb7fba