react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Samuel Susla 9b973f32e4 Fix TextInput value not restoring after reuse

Summary:
Changelog: [Internal]

# Problem

The problem was setting `_backedTextInputView.attributedText` to nil inside `[RCTTextInputComponentView prepareForRecycle]`.

Ordinarily this isn't a problem becase `UIManager::updateState` drops the update if the ShadowNode no longer exists. But in certain cases the ShadowNode can exist, empty string being set as its value

# Fix

Fix is trivial, invalidate state before nullifying `_backedTextInputView`. This prevents the state update from being dispatched.

# Discussion

We should go over all other components and make sure state is invalidated as first thing in `[RCTViewComponentView prepareForRecycle]`.

Reviewed By: shergin

Differential Revision: D23324929

fbshipit-source-id: 9568e920d99683ad95f965ef4b63c529f50f3283

2020-08-25 15:43:08 -07:00

AccessibilityResources/en.lproj

Add localized accessibility strings to React Core pod (#27995 )

2020-02-20 14:31:03 -08:00

Base

Use window size instead of screen size in BottomSheet

2020-08-25 06:50:34 -07:00

CoreModules

Bridgeless support for RCTKeyboardObserver

2020-08-21 13:21:12 -07:00

CxxBridge

Delete unused RCTAdditionalJavaScriptDidLoadNotification