mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
evelant
58adc5e4b9
Summary: Fix build failure on iOS with pnpm and use_frameworks! due to cocoapods copying symlinked headers to wrong paths When using pnpm all packages are symlinked to node_modules/.pnpm to prevent phantom dependency resolution. This causes react-native iOS build to fail because Cocoapods copies headers to incorrect destinations when they're behind symlinks. The fix resolves absolute paths to the header_mappings_dir at pod install time. With absolute paths cocoapods copies the headers correctly. This commit also adds a few missing header search paths in use_frameworks! mode. Fixes https://github.com/facebook/react-native/issues/38140 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [FIXED] - Build failure with pnpm and use_frameworks! due to incorrect header paths For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: https://github.com/facebook/react-native/pull/38158 Test Plan: 1. `pnpm pnpx react-native@latest init AwesomeProject` 2. `cd AwesomeProject` 3. `rm -rf node_modules yarn.lock` 4. `mkdir patches` 5. copy [react-native@0.72.1.patch](https://github.com/facebook/react-native/files/11937570/react-native%400.72.1.patch) to `patches/` 6. Add patch to package.json ``` "pnpm": { "patchedDependencies": { "react-native@0.72.1": "patches/react-native@0.72.1.patch" } } ``` 7. `pnpm install` 8. `cd ios` 9. `NO_FLIPPER=1 USE_FRAMEWORKS=static pod install` 10. `cd ..` 11. `pnpm react-native run-ios` Hopefully an automated test of building with `pnpm` can be added to CI. I don't know how to make that happen, hopefully someone at facebook can do it. Reviewed By: dmytrorykun Differential Revision: D47211946 Pulled By: cipolleschi fbshipit-source-id: 87640bd3f32f023c43291213b5291a7b990d7e1f
74 lines
3.2 KiB
Ruby
74 lines
3.2 KiB
Ruby
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
||
#
|
||
# This source code is licensed under the MIT license found in the
|
||
# LICENSE file in the root directory of this source tree.
|
||
|
||
require "json"
|
||
|
||
package = JSON.parse(File.read(File.join(__dir__, "..", "package.json")))
|
||
version = package['version']
|
||
|
||
source = { :git => 'https://github.com/facebook/react-native.git' }
|
||
if version == '1000.0.0'
|
||
# This is an unpublished version, use the latest commit hash of the react-native repo, which we’re presumably in.
|
||
source[:commit] = `git rev-parse HEAD`.strip if system("git rev-parse --git-dir > /dev/null 2>&1")
|
||
else
|
||
source[:tag] = "v#{version}"
|
||
end
|
||
|
||
folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32 -Wno-gnu-zero-variadic-macro-arguments'
|
||
folly_version = '2021.07.22.00'
|
||
boost_compiler_flags = '-Wno-documentation'
|
||
using_hermes = ENV['USE_HERMES'] == nil || ENV['USE_HERMES'] == "1"
|
||
Pod::Spec.new do |s|
|
||
s.name = "ReactCommon"
|
||
s.module_name = "ReactCommon"
|
||
s.version = version
|
||
s.summary = "-" # TODO
|
||
s.homepage = "https://reactnative.dev/"
|
||
s.license = package["license"]
|
||
s.author = "Meta Platforms, Inc. and its affiliates"
|
||
s.platforms = { :ios => min_ios_version_supported }
|
||
s.source = source
|
||
s.header_dir = "ReactCommon" # Use global header_dir for all subspecs for use_frameworks! compatibility
|
||
s.compiler_flags = folly_compiler_flags + ' ' + boost_compiler_flags
|
||
s.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\" \"$(PODS_ROOT)/RCT-Folly\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/Headers/Private/React-Core\"",
|
||
"USE_HEADERMAP" => "YES",
|
||
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
|
||
"GCC_WARN_PEDANTIC" => "YES" }
|
||
if ENV['USE_FRAMEWORKS']
|
||
s.header_mappings_dir = File.absolute_path("./")
|
||
end
|
||
|
||
# TODO (T48588859): Restructure this target to align with dir structure: "react/nativemodule/..."
|
||
# Note: Update this only when ready to minimize breaking changes.
|
||
s.subspec "turbomodule" do |ss|
|
||
ss.dependency "React-callinvoker", version
|
||
ss.dependency "React-perflogger", version
|
||
ss.dependency "React-cxxreact", version
|
||
ss.dependency "React-jsi", version
|
||
ss.dependency "RCT-Folly", folly_version
|
||
s.dependency "React-logger", version
|
||
ss.dependency "DoubleConversion"
|
||
ss.dependency "glog"
|
||
if using_hermes
|
||
ss.dependency "hermes-engine"
|
||
end
|
||
|
||
ss.subspec "bridging" do |sss|
|
||
sss.dependency "React-jsi", version
|
||
sss.source_files = "react/bridging/**/*.{cpp,h}"
|
||
sss.exclude_files = "react/bridging/tests"
|
||
sss.header_dir = "react/bridging"
|
||
sss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/ReactCommon\" \"$(PODS_ROOT)/RCT-Folly\"" }
|
||
if using_hermes
|
||
sss.dependency "hermes-engine"
|
||
end
|
||
end
|
||
|
||
ss.subspec "core" do |sss|
|
||
sss.source_files = "react/nativemodule/core/ReactCommon/**/*.{cpp,h}"
|
||
end
|
||
end
|
||
end
|