mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ryan Linton
4fb5573796
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44237 This adds support for color function values to ColorPropConverter per the wide gamut color [RFC](https://github.com/react-native-community/discussions-and-proposals/pull/738). It updates the color conversion code so that it returns a Color instance before ultimately being converted to an Integer in preparation for returning long values as needed. ## Changelog: [ANDROID] [ADDED] - Update ColorPropConverter to support color function values Pull Request resolved: https://github.com/facebook/react-native/pull/43031 Test Plan: Colors should work exactly the same as before. Follow test steps from https://github.com/facebook/react-native/pull/42831 to test support for color() function syntax. While colors specified with color() function syntax will not yet render in DisplayP3 color space they will not be misrecognized as resource path colors but will instead fallback to their sRGB color space values. --- After the failure with the tests, I reapplied the changes and test some Jest e2e tests that were failing yesterday: {F1495277376} Reviewed By: cortinico Differential Revision: D56517579 Pulled By: cipolleschi fbshipit-source-id: ae9b5bc2afe9eb9760dd91afb090385daf7102b8