mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
4eef075a58
Summary: Original commit changeset: f1c831a45f96 Original Phabricator Diff: D34552175 (https://github.com/facebook/react-native/commit/6a4e905e3a4cccb7c134e8504a1c6674e23b1b70) Changelog: [Android][Fixed] - Revert back a previous change that could cause null pointer exception on UI manager ---- Context: We were flagged a spiking crash on BizApp v348 (T113279390). We were able to repro the issue on multiple UI components on BizApp so we suspect it's caused by some kind of RN infra issue. Unfortunately the issue can't be always reproed so we can't do a biset. Based on mdvacca's initial assessment, the original diff D34552175 (https://github.com/facebook/react-native/commit/6a4e905e3a4cccb7c134e8504a1c6674e23b1b70) was landed right before version 348.0.0.0.114 was created which aligns with the timeline of the crash (see attached task). We've also tried to backout the diff locally and tested for multiple Pages and seems the crash disappears - so we decided to give it a shot and see if this could mitigate the crash on RC. Reviewed By: mdvacca Differential Revision: D34632014 fbshipit-source-id: ce589d6e7d2293befc3615ecb87a9fc09f6a33f4