mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin Shergin
2e864c176c
Summary: UIScrollView sometimes calls its delegate during its own deallocation and that causes a crash. This change introducing nil-ing the delegate before the deallocation to prevent this. We already had this implemented in D17924429 but D18752886 broke that. This diff fixes that one more time. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D18933934 fbshipit-source-id: 8da22ff4b1fefee712ced25cf0f1c239535554da
74 lines
1.8 KiB
Plaintext
74 lines
1.8 KiB
Plaintext
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import "RCTEnhancedScrollView.h"
|
|
|
|
@implementation RCTEnhancedScrollView {
|
|
__weak id<UIScrollViewDelegate> _publicDelegate;
|
|
}
|
|
|
|
+ (BOOL)automaticallyNotifiesObserversForKey:(NSString *)key
|
|
{
|
|
if ([key isEqualToString:@"delegate"]) {
|
|
// For `delegate` property, we issue KVO notifications manually.
|
|
// We need that to block notifications caused by setting the original `UIScrollView`s property.
|
|
return NO;
|
|
}
|
|
|
|
return [super automaticallyNotifiesObserversForKey:key];
|
|
}
|
|
|
|
- (instancetype)initWithFrame:(CGRect)frame
|
|
{
|
|
if (self = [super initWithFrame:frame]) {
|
|
if (@available(iOS 11.0, *)) {
|
|
// We set the default behavior to "never" so that iOS
|
|
// doesn't do weird things to UIScrollView insets automatically
|
|
// and keeps it as an opt-in behavior.
|
|
self.contentInsetAdjustmentBehavior = UIScrollViewContentInsetAdjustmentNever;
|
|
}
|
|
|
|
__weak __typeof(self) weakSelf = self;
|
|
_delegateSplitter = [[RCTGenericDelegateSplitter alloc] initWithDelegateUpdateBlock:^(id delegate) {
|
|
[weakSelf setPrivateDelegate:delegate];
|
|
}];
|
|
}
|
|
|
|
return self;
|
|
}
|
|
|
|
- (void)setPrivateDelegate:(id<UIScrollViewDelegate>)delegate
|
|
{
|
|
[super setDelegate:delegate];
|
|
}
|
|
|
|
- (id<UIScrollViewDelegate>)delegate
|
|
{
|
|
return _publicDelegate;
|
|
}
|
|
|
|
- (void)setDelegate:(id<UIScrollViewDelegate>)delegate
|
|
{
|
|
if (_publicDelegate == delegate) {
|
|
return;
|
|
}
|
|
|
|
if (_publicDelegate) {
|
|
[_delegateSplitter removeDelegate:_publicDelegate];
|
|
}
|
|
|
|
[self willChangeValueForKey:@"delegate"];
|
|
_publicDelegate = delegate;
|
|
[self didChangeValueForKey:@"delegate"];
|
|
|
|
if (_publicDelegate) {
|
|
[_delegateSplitter addDelegate:_publicDelegate];
|
|
}
|
|
}
|
|
|
|
@end
|