mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin SherginandFacebook GitHub Bot
00e038689d
Summary: Even though replacing an error with a warning does not look like a future-proof solution here are the reasons for this: * The measuring operation might just fail because of the async nature of React Native. And here, from my understanding, we don't even have a good reason for measuring. Auto-scrolling to selected textinput (which is the reason for this code, AFAIK) is a standard feature that OS does for all text input. I suspect that this (very old) feature was built in a timeframe where this system feature was originally broken (sometime before 2016). * This product-facing API does not have an error-callback, so just loggin an error here is as (not) actionable as logging a warning. * The error callback was never implemented in the pre-Fabric world, so it *never* got called for years, and now when Fabric is starting calling in some cases, it is being "punished" for this. In the next diff, I will try to retrofit this feature back to Paper to reach parity with Paper. Changelog: [Internal] Differential Revision: D25700156 fbshipit-source-id: 319a146b17cc2130848148ad11adbde16e86c5d5