Moti Zilberman 60b4ba16c0 Always return 0-based columns from parseErrorStack ...

Summary:
Fixes a bug where we were skewing some stack traces by sending 1-based column numbers to the Metro symbolication endpoint, which expects them to be 0-based. This is achieved by subtracting 1 from the column numbers we find in textual stack traces, which are almost universally 1-based in current JS engines.

The bug is only noticeable in *some* cases, namely where the column immediately following the correct one is in a different function.

NOTE: The behaviour under Hermes was fixed separately, in a previous commit. This fix applies to other engines (e.g. JSC).

Changelog: [General] [Fixed] - Fix stack traces showing the wrong function name in some cases

Reviewed By: cpojer

Differential Revision: D18628230

fbshipit-source-id: 5677803500e45a41c1005496d19c150526af2d07

2019-12-02 06:02:25 -08:00

..

__tests__

Implement a dedicated Hermes stack trace parser

2019-12-02 06:02:25 -08:00

getDevServer.js

Exact-by-default codemod for react-native-github

2019-11-21 09:42:57 -08:00

openFileInEditor.js

Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749)

2019-05-08 08:48:59 -07:00

openURLInBrowser.js

Open links from new app screen in computer's browser (#24843)

2019-05-14 07:07:24 -07:00

parseErrorStack.js

Always return 0-based columns from parseErrorStack

2019-12-02 06:02:25 -08:00

parseHermesStack.js

Implement a dedicated Hermes stack trace parser

2019-12-02 06:02:25 -08:00

symbolicateStackTrace.js

Parse any babel codeframe error as syntax error

2019-11-27 09:25:04 -08:00