mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Summary: This PR is in response to https://github.com/facebook/react-native/pull/39758#discussion_r1344839022 . `RCTConvert.h` currently takes an import of `<Webkit/Webkit.h>` for... one enum: `WKDataDetectorTypes`. This has a few problems: 1) RCTConvert is JS engine agnostic, it shouldn't be depending on Webkit 2) As far as I can tell, this code is dead, we also define (and use) the UIKit equivalent `UIDataDetectorTypes`. Let's just combine the two, update some JS typing, and get rid of the Webkit header import. ## Changelog: [IOS] [CHANGED] - Remove `<Webkit/Webkit.h>` import in `RCTConvert.h` Pull Request resolved: https://github.com/facebook/react-native/pull/39794 Test Plan: CI should pass Reviewed By: rshest Differential Revision: D49898701 Pulled By: NickGerleman fbshipit-source-id: 5420cb62317e1186426aae019bcc43d27c49ea26