mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Riccardo Cipolleschi
d72697ca95
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36385 This change moves the `graphics/conversions.h` files from `ReactCommon/react/renderer/graphics` to `ReactCommon/react/renderer/core`, renaming it to `graphicsConversions.h`. This is required because React-Fabric imports graphics, but graphics imports React-Fabric due to this file. The change would be breaking, but we don't want to break the ecosystem without even a warning. So, we put back the `conversions.h` file, which now just `include` the new one and outputs a warning when building. This actually maintain the dep cycle for the current version, but at least users are warned. ## Changelog: [iOS][Deprecated] - Deprecate the `ReactCommon/react/renderer/graphics/conversions.h` in favor of `ReactCommon/react/core/graphicsConversions.h` Reviewed By: cortinico, dmytrorykun Differential Revision: D43836261 fbshipit-source-id: ffe53a8ce2b0ea2dd1e1e5aaf6b3d3c5b57ad46d
28 lines
1.3 KiB
C
28 lines
1.3 KiB
C
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <react/renderer/core/graphicsConversions.h>
|
|
|
|
// This file belongs to the React-graphics module.
|
|
// This file also used to have a reference to two files that are located in the
|
|
// react/renderer/core folder. That folder belongs to a module that is called
|
|
// React-Fabric.
|
|
// The React-Fabric module declares an explicit dependency on
|
|
// React-graphics. Including those files in a React-graphics' file created a
|
|
// circular dependency because React-Fabric was explicitly depending on
|
|
// React-graphics, which was implicitly depending on React-Fabric. We break that
|
|
// dependency by moving the old `graphics/conversions.h` file to the
|
|
// React-Fabric module and renaming it `core/graphicsConversions.h`.
|
|
|
|
#warning \
|
|
"[DEPRECATION] `graphics/conversions.h` is deprecated and will be removed in the future. \
|
|
If this warning appears due to a library, please open an issue in that library, and ask for an update. \
|
|
Please, replace the `#include <react/renderer/graphics/conversions.h>` statements \
|
|
with `#include <react/renderer/core/graphicsConversions.h>`."
|