Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
42ac240bceb104474494c6007df0089baec00f7a
react-native/Libraries/Core
T
History
Rick Hanlon 42ac240bce Don't wrap console methods for metro logging in Chrome debugger (#26883) 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/26883

This diff fixes an issue reported in https://github.com/facebook/react-native/issues/26788 where logs in the Chrome console were showing a different location than previous versions.

In the change here, we stop wrapping the console functions to attach the metro websocket in any environment that isn't a native app environment. We do this by checking `global.nativeLoggingHook` which is bound only by native apps and not environments like the Chrome DevTools.

Changelog: [General][Fixed] - Fix wrong lines logging in Chrome debugger

Reviewed By: cpojer, gaearon

Differential Revision: D17951707

fbshipit-source-id: f045ea9abaa8aecc6afb8eca7db9842146a3d872
2019-10-21 10:05:40 -07:00
..
__mocks__
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
__tests__
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
Devtools
Type StackFrame fields as nullable
2019-07-31 09:08:06 -07:00
SegmentFetcher
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
Timers
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
checkNativeVersion.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ExceptionsManager.js
Reuse preprocessed exception message in redbox after symbolication
2019-09-12 03:55:41 -07:00
InitializeCore.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeExceptionsManager.js
Fix Redbox on iOS
2019-08-30 18:10:35 -07:00
polyfillPromise.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReactFiberErrorDialog.js
Move React error message formatting into ExceptionsManager
2019-07-31 02:34:15 -07:00
ReactNativeVersion.js
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
ReactNativeVersionCheck.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpAlert.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpBatchedBridge.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpDeveloperTools.js
Don't wrap console methods for metro logging in Chrome debugger (#26883)
2019-10-21 10:05:40 -07:00
setUpErrorHandling.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpGlobals.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpNavigator.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpReactRefresh.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpRegeneratorRuntime.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpSegmentFetcher.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpSystrace.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpTimers.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
setUpXHR.js
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00