mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
edenb-moveo
6c080167e6
Summary: Currently ImageBackGround component has optional style props, but if you don't pass it as prop, it still "thinks" you pass style and crushes. In this pr, I made width and height inside component to be optional so it won't crush. ## Changelog [General] [Fix] - Changed ImageBackground's style so it won't crush. [Screen Shot 2021-08-20 at 15 05 45](https://user-images.githubusercontent.com/62840630/130230568-be02b1a2-52ec-4f9d-b3d3-212552d3882b.png) As you can see in this component, I tried to use ImageBackground without any style props, and my app crushes. Then I added style with empty object and the app didn't crush anymore, as you can see here: . In conclusion, if we make width and height styles optionals inside ImageBackground component, it won't crush anymore. Thoughts: Maybe consider to make style props for this component none-optional because it isn't make any sense that image won't have any style at all. Thanks ahead, that was my first pr, Eden Binyamin. Pull Request resolved: https://github.com/facebook/react-native/pull/32055 Reviewed By: charlesbdudley Differential Revision: D30452297 Pulled By: sshic fbshipit-source-id: b7071aa457dba443ed2f627c2458ea84fd24b36d
91 lines
2.5 KiB
JavaScript
91 lines
2.5 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
* @format
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const Image = require('./Image');
|
|
const React = require('react');
|
|
const StyleSheet = require('../StyleSheet/StyleSheet');
|
|
const View = require('../Components/View/View');
|
|
|
|
/**
|
|
* Very simple drop-in replacement for <Image> which supports nesting views.
|
|
*
|
|
* ```ReactNativeWebPlayer
|
|
* import React, { Component } from 'react';
|
|
* import { AppRegistry, View, ImageBackground, Text } from 'react-native';
|
|
*
|
|
* class DisplayAnImageBackground extends Component {
|
|
* render() {
|
|
* return (
|
|
* <ImageBackground
|
|
* style={{width: 50, height: 50}}
|
|
* source={{uri: 'https://reactnative.dev/img/opengraph.png'}}
|
|
* >
|
|
* <Text>React</Text>
|
|
* </ImageBackground>
|
|
* );
|
|
* }
|
|
* }
|
|
*
|
|
* // App registration and rendering
|
|
* AppRegistry.registerComponent('DisplayAnImageBackground', () => DisplayAnImageBackground);
|
|
* ```
|
|
*/
|
|
class ImageBackground extends React.Component<$FlowFixMeProps> {
|
|
setNativeProps(props: Object) {
|
|
// Work-around flow
|
|
const viewRef = this._viewRef;
|
|
if (viewRef) {
|
|
viewRef.setNativeProps(props);
|
|
}
|
|
}
|
|
|
|
_viewRef: ?React.ElementRef<typeof View> = null;
|
|
|
|
_captureRef = ref => {
|
|
this._viewRef = ref;
|
|
};
|
|
|
|
render(): React.Node {
|
|
const {children, style, imageStyle, imageRef, ...props} = this.props;
|
|
|
|
return (
|
|
<View
|
|
accessibilityIgnoresInvertColors={true}
|
|
style={style}
|
|
ref={this._captureRef}>
|
|
<Image
|
|
{...props}
|
|
style={[
|
|
StyleSheet.absoluteFill,
|
|
{
|
|
// Temporary Workaround:
|
|
// Current (imperfect yet) implementation of <Image> overwrites width and height styles
|
|
// (which is not quite correct), and these styles conflict with explicitly set styles
|
|
// of <ImageBackground> and with our internal layout model here.
|
|
// So, we have to proxy/reapply these styles explicitly for actual <Image> component.
|
|
// This workaround should be removed after implementing proper support of
|
|
// intrinsic content size of the <Image>.
|
|
width: style?.width,
|
|
height: style?.height,
|
|
},
|
|
imageStyle,
|
|
]}
|
|
ref={imageRef}
|
|
/>
|
|
{children}
|
|
</View>
|
|
);
|
|
}
|
|
}
|
|
|
|
module.exports = ImageBackground;
|