mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Summary:
On iPadOS, users can change the kind of keyboard displayed onscreen, going from normal keyboard, to split keyboard (one half on the left of the screen, one half on the right), or a floating keyboard that you can move around the screen.
When a non-normal kind of keyboard is used, `<KeyboardAvoidingView>` calculations are all wrong and, depending on the `behavior` prop, can make your screen completely hidden.
This PR attempts to detect that the keyboard is not the "normal displayed-at-bottom-of-screen" keyboard, and forces `enable={false}` if this happens.
The approach of comparing the keyboard width with the window width comes from this comment: https://github.com/facebook/react-native/issues/29473#issuecomment-696658937
A better fix might be to detect the kind of keyboard used, but this involves native code changes and I do not know iOS enough to do that. In addition, I have not found an easy way to do it using iOS APIs after a quick search.
I also chose to cache the window width as a class attribute. Maybe this is not needed as `Dimensions.get('window').width` is very fast and can be called on every keyboard event?
This fixes https://github.com/facebook/react-native/issues/44068 and https://github.com/facebook/react-native/issues/29473
## Changelog:
[IOS] [FIXED] - Fix `<KeyboardAvoidingView>` with floating keyboard on iPadOS
Pull Request resolved: https://github.com/facebook/react-native/pull/44859
Test Plan:
Tested using RNTester and the "Keyboard Avoiding View with different behaviors" example.
Before:
https://github.com/facebook/react-native/assets/42070/111598a3-286c-464d-8db8-73afb35cd7f9
After:
https://github.com/facebook/react-native/assets/42070/0b3bc94f-8b67-4f42-8a83-e11555080268
Reviewed By: cortinico
Differential Revision: D62844854
Pulled By: cipolleschi
fbshipit-source-id: 577444be50019572955a013969d78178914b5b8d
291 lines
8.1 KiB
JavaScript
291 lines
8.1 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @flow strict-local
|
|
*/
|
|
|
|
import type {ViewStyleProp} from '../../StyleSheet/StyleSheet';
|
|
import type {DimensionsPayload} from '../../Utilities/NativeDeviceInfo';
|
|
import type {
|
|
ViewLayout,
|
|
ViewLayoutEvent,
|
|
ViewProps,
|
|
} from '../View/ViewPropTypes';
|
|
import type {KeyboardEvent, KeyboardMetrics} from './Keyboard';
|
|
|
|
import LayoutAnimation from '../../LayoutAnimation/LayoutAnimation';
|
|
import StyleSheet from '../../StyleSheet/StyleSheet';
|
|
import Dimensions from '../../Utilities/Dimensions';
|
|
import Platform from '../../Utilities/Platform';
|
|
import {type EventSubscription} from '../../vendor/emitter/EventEmitter';
|
|
import AccessibilityInfo from '../AccessibilityInfo/AccessibilityInfo';
|
|
import View from '../View/View';
|
|
import Keyboard from './Keyboard';
|
|
import * as React from 'react';
|
|
|
|
type Props = $ReadOnly<{|
|
|
...ViewProps,
|
|
|
|
/**
|
|
* Specify how to react to the presence of the keyboard.
|
|
*/
|
|
behavior?: ?('height' | 'position' | 'padding'),
|
|
|
|
/**
|
|
* Style of the content container when `behavior` is 'position'.
|
|
*/
|
|
contentContainerStyle?: ?ViewStyleProp,
|
|
|
|
/**
|
|
* Controls whether this `KeyboardAvoidingView` instance should take effect.
|
|
* This is useful when more than one is on the screen. Defaults to true.
|
|
*/
|
|
enabled?: ?boolean,
|
|
|
|
/**
|
|
* Distance between the top of the user screen and the React Native view. This
|
|
* may be non-zero in some cases. Defaults to 0.
|
|
*/
|
|
keyboardVerticalOffset?: number,
|
|
|}>;
|
|
|
|
type State = {|
|
|
bottom: number,
|
|
|};
|
|
|
|
/**
|
|
* View that moves out of the way when the keyboard appears by automatically
|
|
* adjusting its height, position, or bottom padding.
|
|
*/
|
|
class KeyboardAvoidingView extends React.Component<Props, State> {
|
|
_frame: ?ViewLayout = null;
|
|
_keyboardEvent: ?KeyboardEvent = null;
|
|
_subscriptions: Array<EventSubscription> = [];
|
|
viewRef: {current: React.ElementRef<typeof View> | null, ...};
|
|
_initialFrameHeight: number = 0;
|
|
_bottom: number = 0;
|
|
_windowWidth: number = Dimensions.get('window').width;
|
|
|
|
constructor(props: Props) {
|
|
super(props);
|
|
this.state = {bottom: 0};
|
|
this.viewRef = React.createRef();
|
|
}
|
|
|
|
async _relativeKeyboardHeight(
|
|
keyboardFrame: KeyboardMetrics,
|
|
): Promise<number> {
|
|
const frame = this._frame;
|
|
if (!frame || !keyboardFrame) {
|
|
return 0;
|
|
}
|
|
|
|
// On iOS when Prefer Cross-Fade Transitions is enabled, the keyboard position
|
|
// & height is reported differently (0 instead of Y position value matching height of frame)
|
|
if (
|
|
Platform.OS === 'ios' &&
|
|
keyboardFrame.screenY === 0 &&
|
|
(await AccessibilityInfo.prefersCrossFadeTransitions())
|
|
) {
|
|
return 0;
|
|
}
|
|
|
|
const keyboardY =
|
|
keyboardFrame.screenY - (this.props.keyboardVerticalOffset ?? 0);
|
|
|
|
if (this.props.behavior === 'height') {
|
|
return Math.max(
|
|
this.state.bottom + frame.y + frame.height - keyboardY,
|
|
0,
|
|
);
|
|
}
|
|
|
|
// Calculate the displacement needed for the view such that it
|
|
// no longer overlaps with the keyboard
|
|
return Math.max(frame.y + frame.height - keyboardY, 0);
|
|
}
|
|
|
|
_onKeyboardChange = (event: ?KeyboardEvent) => {
|
|
this._keyboardEvent = event;
|
|
// $FlowFixMe[unused-promise]
|
|
this._updateBottomIfNecessary();
|
|
};
|
|
|
|
_onLayout = async (event: ViewLayoutEvent) => {
|
|
const oldFrame = this._frame;
|
|
this._frame = event.nativeEvent.layout;
|
|
if (!this._initialFrameHeight) {
|
|
// save the initial frame height, before the keyboard is visible
|
|
this._initialFrameHeight = this._frame.height;
|
|
}
|
|
|
|
// update bottom height for the first time or when the height is changed
|
|
if (!oldFrame || oldFrame.height !== this._frame.height) {
|
|
await this._updateBottomIfNecessary();
|
|
}
|
|
|
|
if (this.props.onLayout) {
|
|
this.props.onLayout(event);
|
|
}
|
|
};
|
|
|
|
_onDimensionsChange = ({window}: DimensionsPayload) => {
|
|
this._windowWidth = window?.width ?? 0;
|
|
};
|
|
|
|
// Avoid unnecessary renders if the KeyboardAvoidingView is disabled.
|
|
_setBottom = (value: number) => {
|
|
const enabled = this.props.enabled ?? true;
|
|
this._bottom = value;
|
|
if (enabled) {
|
|
this.setState({bottom: value});
|
|
}
|
|
};
|
|
|
|
_updateBottomIfNecessary = async () => {
|
|
if (this._keyboardEvent == null) {
|
|
this._setBottom(0);
|
|
return;
|
|
}
|
|
|
|
if (
|
|
Platform.OS === 'ios' &&
|
|
this._windowWidth !== this._keyboardEvent.endCoordinates.width
|
|
) {
|
|
// The keyboard is not the standard bottom-of-the-screen keyboard. For example, floating keyboard on iPadOS.
|
|
this._setBottom(0);
|
|
return;
|
|
}
|
|
|
|
const {duration, easing, endCoordinates} = this._keyboardEvent;
|
|
const height = await this._relativeKeyboardHeight(endCoordinates);
|
|
|
|
if (this._bottom === height) {
|
|
return;
|
|
}
|
|
|
|
this._setBottom(height);
|
|
|
|
const enabled = this.props.enabled ?? true;
|
|
if (enabled && duration && easing) {
|
|
LayoutAnimation.configureNext({
|
|
// We have to pass the duration equal to minimal accepted duration defined here: RCTLayoutAnimation.m
|
|
duration: duration > 10 ? duration : 10,
|
|
update: {
|
|
duration: duration > 10 ? duration : 10,
|
|
type: LayoutAnimation.Types[easing] || 'keyboard',
|
|
},
|
|
});
|
|
}
|
|
};
|
|
|
|
componentDidUpdate(_: Props, prevState: State): void {
|
|
const enabled = this.props.enabled ?? true;
|
|
if (enabled && this._bottom !== prevState.bottom) {
|
|
this.setState({bottom: this._bottom});
|
|
}
|
|
}
|
|
|
|
componentDidMount(): void {
|
|
if (Platform.OS === 'ios') {
|
|
this._subscriptions = [
|
|
Keyboard.addListener('keyboardWillChangeFrame', this._onKeyboardChange),
|
|
Dimensions.addEventListener('change', this._onDimensionsChange),
|
|
];
|
|
} else {
|
|
this._subscriptions = [
|
|
Keyboard.addListener('keyboardDidHide', this._onKeyboardChange),
|
|
Keyboard.addListener('keyboardDidShow', this._onKeyboardChange),
|
|
];
|
|
}
|
|
}
|
|
|
|
componentWillUnmount(): void {
|
|
this._subscriptions.forEach(subscription => {
|
|
subscription.remove();
|
|
});
|
|
}
|
|
|
|
render(): React.Node {
|
|
const {
|
|
behavior,
|
|
children,
|
|
contentContainerStyle,
|
|
enabled = true,
|
|
// eslint-disable-next-line no-unused-vars
|
|
keyboardVerticalOffset = 0,
|
|
style,
|
|
onLayout,
|
|
...props
|
|
} = this.props;
|
|
const bottomHeight = enabled === true ? this.state.bottom : 0;
|
|
switch (behavior) {
|
|
case 'height':
|
|
let heightStyle;
|
|
if (this._frame != null && this.state.bottom > 0) {
|
|
// Note that we only apply a height change when there is keyboard present,
|
|
// i.e. this.state.bottom is greater than 0. If we remove that condition,
|
|
// this.frame.height will never go back to its original value.
|
|
// When height changes, we need to disable flex.
|
|
heightStyle = {
|
|
height: this._initialFrameHeight - bottomHeight,
|
|
flex: 0,
|
|
};
|
|
}
|
|
return (
|
|
<View
|
|
ref={this.viewRef}
|
|
style={StyleSheet.compose(style, heightStyle)}
|
|
onLayout={this._onLayout}
|
|
{...props}>
|
|
{children}
|
|
</View>
|
|
);
|
|
|
|
case 'position':
|
|
return (
|
|
<View
|
|
ref={this.viewRef}
|
|
style={style}
|
|
onLayout={this._onLayout}
|
|
{...props}>
|
|
<View
|
|
style={StyleSheet.compose(contentContainerStyle, {
|
|
bottom: bottomHeight,
|
|
})}>
|
|
{children}
|
|
</View>
|
|
</View>
|
|
);
|
|
|
|
case 'padding':
|
|
return (
|
|
<View
|
|
ref={this.viewRef}
|
|
style={StyleSheet.compose(style, {paddingBottom: bottomHeight})}
|
|
onLayout={this._onLayout}
|
|
{...props}>
|
|
{children}
|
|
</View>
|
|
);
|
|
|
|
default:
|
|
return (
|
|
<View
|
|
ref={this.viewRef}
|
|
onLayout={this._onLayout}
|
|
style={style}
|
|
{...props}>
|
|
{children}
|
|
</View>
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
export default KeyboardAvoidingView;
|