Files
react-native/ReactCommon/fabric/components/activityindicator/conversions.h
T
Valentin SherginandFacebook Github Bot 9842e39019 Fabric: folly::dynamic was replaced with RawValue in prop-parsing infra
Summary:
Our long-term plan is to completely illuminate `jsi::Value`-to-`folly::dynamic` serialization step in prop parsing process improving performance and memory pressure. At the same time, we don't want to introduce a hard dependency in application code to JSI because it exposes direct access to VM and prevents parsing some data that come *NOT* from JSVM.
RawValue is an extremely light-weight (hopefully fully optimized-out) abstraction that provides limited JSON-like and C++-idiomatic interface.

The current particular implementation is still using `folly::dynamic` inside, but I have fully JSI-powered one which will replace the current one right after we figure out how to deal with folly::dynamic-specific callsites. Or we can implement RawValue in a hybrid manner if a code-size implication of that will be minimal.

Reviewed By: JoshuaGross, mdvacca

Differential Revision: D13962466

fbshipit-source-id: e848522fd242f21e9e771773f2103f1c1d9d7f21
2019-02-06 16:34:46 -08:00

42 lines
926 B
C++

/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#pragma once
#include <folly/dynamic.h>
#include <react/components/activityindicator/primitives.h>
namespace facebook {
namespace react {
inline void fromRawValue(
const RawValue &value,
ActivityIndicatorViewSize &result) {
auto string = (std::string)value;
if (string == "large") {
result = ActivityIndicatorViewSize::Large;
return;
}
if (string == "small") {
result = ActivityIndicatorViewSize::Small;
return;
}
abort();
}
inline std::string toString(const ActivityIndicatorViewSize &value) {
switch (value) {
case ActivityIndicatorViewSize::Large:
return "large";
case ActivityIndicatorViewSize::Small:
return "small";
}
}
} // namespace react
} // namespace facebook