mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel Susla
a9e7da12af
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36699 Changelog: [internal] This fixes a crash introduced in D43692171 where `jsi::Pointer` outlives `jsi::Runtime` in which it was created. This leads to a crash. The diff changed ownership model, retaining `TextLayoutManager` strongly from `ParagraphState`. To resolve this, in this diff we change how `StateWrapperImpl` owns state, moving from shared_ptr to weak_ptr. We have tried to do it previously in D26815275 but it had to be reverted because it broke end to end tests. I made sure the tests are fine. However it is the right ownership model. Java objects should not strongly hold onto anything in ShadowTree. If ShadowTree is destroyed, Java calls should noop, not keep objects in memory and have them handle the case when runtime was destroyed. jest_e2e[run_all_tests] Reviewed By: cipolleschi Differential Revision: D44472121 fbshipit-source-id: 83b79329440ac1211902ea9511c0dde9a77ab9e9