mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ruslan ShestopalyukandFacebook GitHub Bot
a142a78473
Summary: Changelog: [Android][Fixed] - Fix regression when setting shadow node properties. Also simplified the corresponding macros to avoid using lambdas altogether, as they are not required. Note that this **does not** modify any constexpr-related semantics of the existing code, as the main constexpr macro, `CONSTEXPR_RAW_PROPS_KEY_HASH` evaluation result is still contstexpr value, and the other ones already involved non-const parts (see my comments). Reviewed By: NickGerleman Differential Revision: D38356411 fbshipit-source-id: 22c330d3425c8aed36693f4652f1b257d2dc96be
93 lines
4.7 KiB
C++
93 lines
4.7 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <react/renderer/core/RawPropsPrimitives.h>
|
|
|
|
// We need to use clang pragmas inside of a macro below,
|
|
// so we need to pull out the "if" statement here.
|
|
#if __clang__
|
|
#define CLANG_PRAGMA(s) _Pragma(s)
|
|
#else
|
|
#define CLANG_PRAGMA(s)
|
|
#endif
|
|
|
|
// Get hash at compile-time. sizeof(str) - 1 == strlen
|
|
#define CONSTEXPR_RAW_PROPS_KEY_HASH(s) \
|
|
([]() constexpr->RawPropsPropNameHash { \
|
|
CLANG_PRAGMA("clang diagnostic push") \
|
|
CLANG_PRAGMA("clang diagnostic ignored \"-Wshadow\"") \
|
|
return folly::hash::fnv32_buf(s, sizeof(s) - 1); \
|
|
CLANG_PRAGMA("clang diagnostic pop") \
|
|
}())
|
|
|
|
#define RAW_PROPS_KEY_HASH(s) folly::hash::fnv32_buf(s, std::strlen(s))
|
|
|
|
// Convenience for building setProps switch statements.
|
|
// This injects `fromRawValue` into source; each file that uses
|
|
// this macro must import the proper, respective headers required.
|
|
#define RAW_SET_PROP_SWITCH_CASE(field, jsPropName, defaultValue) \
|
|
case CONSTEXPR_RAW_PROPS_KEY_HASH(jsPropName): \
|
|
fromRawValue(context, value, field, defaultValue); \
|
|
return;
|
|
|
|
// Convenience for building setProps switch statements where the field name is
|
|
// the same as the string identifier
|
|
#define RAW_SET_PROP_SWITCH_CASE_BASIC(field, defaultValue) \
|
|
RAW_SET_PROP_SWITCH_CASE(field, #field, defaultValue)
|
|
|
|
#define CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, field, fieldNameString, value) \
|
|
case CONSTEXPR_RAW_PROPS_KEY_HASH(fieldNameString): { \
|
|
if (!value.hasValue()) { \
|
|
decltype(struct) defaultValues{}; \
|
|
struct.field = defaultValues.field; \
|
|
return; \
|
|
} \
|
|
fromRawValue(context, value, struct.field); \
|
|
return; \
|
|
}
|
|
|
|
#define SET_CASCADED_RECTANGLE_CORNERS(struct, prefix, suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, topLeft, prefix "TopLeft" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, topRight, prefix "TopRight" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, bottomLeft, prefix "BottomLeft" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, bottomRight, prefix "BottomRight" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, topStart, prefix "TopStart" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, topEnd, prefix "TopEnd" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, bottomStart, prefix "BottomStart" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, bottomEnd, prefix "BottomEnd" suffix, rawValue)
|
|
|
|
#define SET_CASCADED_RECTANGLE_EDGES(struct, prefix, suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, left, prefix "Left" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, right, prefix "Right" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, top, prefix "Top" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, bottom, prefix "Bottom" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, start, prefix "Start" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, end, prefix "End" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, horizontal, prefix "Horizontal" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, vertical, prefix "Vertical" suffix, rawValue) \
|
|
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
|
|
struct, all, prefix "" suffix, rawValue)
|