mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Riccardo Cipolleschi
abad576174
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42230 While developing Xcode 15, Apple reimplemented the linker. In Xcode 15.0, the linker was making old iOS (< 15) crash when they were built using Xcode 15. To fix that, we make Apple create new compiler flags (`-ld_classic`) to have a backward compatible linker. In Xcode 15.1, Apple fixed that behavior, so the flags should not be required anymore. But now, if we pass `-ld_classic` to the linker and we have an app that is using `use_framworks!`, that app crashes at startup. This change remove the flags if the Xcode that is used is 15.1 or greater. *Note:* The previous change added the flags to Hermes as well. I tested this fix in a configuration where Hermes has the flags and React Native does not, and it works. So we are removing the flags only from React Native. This Fixes https://github.com/facebook/react-native/issues/39945 ## Changelog: [Internal] - Do not add the `-ld_classic` flag if the app is built with Xcode 15.1 or greater. Reviewed By: cortinico Differential Revision: D52658197 fbshipit-source-id: 37d6bc895921c0fc3661f301870477191e7e42b3