react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Brian Zhao 417e191a1c Correctly bypass sync calls in UIManager during remote debugging (#25162 )

Summary:
Remote debugging stopped working (since 0.58, according to #23254). See https://github.com/facebook/react-native/issues/23254#issuecomment-474692753 for repro steps.

The root cause is incorrect checks for Chrome debugging environment in `UIManager.js`.
- In one place where sync function `lazilyLoadView` should be avoided, we effectively use `if (__DEV__ && !global.nativeCallSyncHook)` to check remote debugging, which misses ship flavor (i.e. `__DEV__` is false).
- In another place where we want to pre-populate view managers' constants to avoid calling sync function `getConstantsForViewManager`, `if (__DEV__)` is used, also missing ship flavor.

This PR fixes both checks, only using the absense of `global.nativeCallSyncHook` to determine remote debugging environments.

## Changelog

[JavaScript] [Fixed] - Correctly bypass sync calls in UIManager during remote debugging
Pull Request resolved: https://github.com/facebook/react-native/pull/25162

Differential Revision: D15692492

Pulled By: cpojer

fbshipit-source-id: 173b688f140916b767fcdbbaaf68a5c303adbcd1

2019-06-06 04:27:52 -07:00

AppContainer.js

Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749 )

2019-05-08 08:48:59 -07:00

AppRegistry.js

add spec for HeadlessJsTaskSupport (#24907 )

2019-05-20 18:05:55 -07:00

FabricUIManager.js

Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749 )

2019-05-08 08:48:59 -07:00

getNativeComponentAttributes.js

Add handling for ColorArray