mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Jimmy ZhangandFacebook GitHub Bot
3d882495d5
Summary: Changelog: Adding packager running check when RCTBundleURLProvider is returning JSLocation, this prevents an invalid address from being returned which might cause various issues. Reviewed By: cpojer Differential Revision: D22390156 fbshipit-source-id: a20dbf63103158a34cbf6dc0ae8349b2f9e5b0a8
108 lines
3.0 KiB
Objective-C
108 lines
3.0 KiB
Objective-C
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <XCTest/XCTest.h>
|
|
|
|
#import <React/RCTBundleURLProvider.h>
|
|
#import <React/RCTUtils.h>
|
|
|
|
#import "OCMock/OCMock.h"
|
|
|
|
static NSString *const testFile = @"test.jsbundle";
|
|
static NSString *const mainBundle = @"main.jsbundle";
|
|
|
|
static NSURL *mainBundleURL()
|
|
{
|
|
return [[[NSBundle mainBundle] bundleURL] URLByAppendingPathComponent:mainBundle];
|
|
}
|
|
|
|
static NSURL *localhostBundleURL()
|
|
{
|
|
return [NSURL
|
|
URLWithString:
|
|
[NSString
|
|
stringWithFormat:
|
|
@"http://localhost:8081/%@.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.apple.dt.xctest.tool",
|
|
testFile]];
|
|
}
|
|
|
|
static NSURL *ipBundleURL()
|
|
{
|
|
return [NSURL
|
|
URLWithString:
|
|
[NSString
|
|
stringWithFormat:
|
|
@"http://192.168.1.1:8081/%@.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.apple.dt.xctest.tool",
|
|
testFile]];
|
|
}
|
|
|
|
@implementation NSBundle (RCTBundleURLProviderTests)
|
|
|
|
- (NSURL *)RCT_URLForResource:(NSString *)name withExtension:(NSString *)ext
|
|
{
|
|
// Ensure that test files is always reported as existing
|
|
if ([[name stringByAppendingFormat:@".%@", ext] isEqualToString:mainBundle]) {
|
|
return [[self bundleURL] URLByAppendingPathComponent:mainBundle];
|
|
}
|
|
return [self RCT_URLForResource:name withExtension:ext];
|
|
}
|
|
|
|
@end
|
|
|
|
@interface RCTBundleURLProviderTests : XCTestCase
|
|
@end
|
|
|
|
@implementation RCTBundleURLProviderTests
|
|
|
|
- (void)setUp
|
|
{
|
|
[super setUp];
|
|
|
|
RCTSwapInstanceMethods(
|
|
[NSBundle class], @selector(URLForResource:withExtension:), @selector(RCT_URLForResource:withExtension:));
|
|
}
|
|
|
|
- (void)tearDown
|
|
{
|
|
RCTSwapInstanceMethods(
|
|
[NSBundle class], @selector(URLForResource:withExtension:), @selector(RCT_URLForResource:withExtension:));
|
|
|
|
[super tearDown];
|
|
}
|
|
|
|
- (void)testBundleURL
|
|
{
|
|
RCTBundleURLProvider *settings = [RCTBundleURLProvider sharedSettings];
|
|
settings.jsLocation = nil;
|
|
NSURL *URL = [settings jsBundleURLForBundleRoot:testFile fallbackResource:nil];
|
|
if (!getenv("CI_USE_PACKAGER")) {
|
|
XCTAssertEqualObjects(URL, mainBundleURL());
|
|
} else {
|
|
XCTAssertEqualObjects(URL, localhostBundleURL());
|
|
}
|
|
}
|
|
|
|
- (void)testLocalhostURL
|
|
{
|
|
RCTBundleURLProvider *settings = [RCTBundleURLProvider sharedSettings];
|
|
settings.jsLocation = @"localhost";
|
|
NSURL *URL = [settings jsBundleURLForBundleRoot:testFile fallbackResource:nil];
|
|
XCTAssertEqualObjects(URL, localhostBundleURL());
|
|
}
|
|
|
|
- (void)testIPURL
|
|
{
|
|
id classMock = OCMClassMock([RCTBundleURLProvider class]);
|
|
[[[classMock stub] andReturnValue:@YES] isPackagerRunning:[OCMArg any]];
|
|
RCTBundleURLProvider *settings = [RCTBundleURLProvider sharedSettings];
|
|
settings.jsLocation = @"192.168.1.1";
|
|
NSURL *URL = [settings jsBundleURLForBundleRoot:testFile fallbackResource:nil];
|
|
XCTAssertEqualObjects(URL, ipBundleURL());
|
|
}
|
|
|
|
@end
|