mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Nick Gerleman
355ca28b5d
Summary: D57285584 was reverted because we have service code with a faulty measure function, and adding logging to Yoga when invalid measurements were received was enough to spike error rate to elevated levels and block release. This is a reland of the below change, with a couple modifications: 1. We log warnings instead of errors, which from what I heard, shouldn't block release, but should still make signal 2. We only zero the dimension which was NaN, to preserve exact behavior ## Original We've started seeing assertion failures in Yoga where a `NaN` value makes its way to an `availableHeight` constraint when measuring Litho tree. Because it's only happening on Litho, I have some suspicion this might be originating from a Litho-specific measure function. This adds sanitization in Yoga to measure function results, where we will log an error, and set size to zero, if either dimension ends up being negative of `NaN`. This doesn't really help track down where the error was happening, but Yoga doesn't have great context to show this to begin with. If we see this is issue, next steps would be Litho internal intrumentation to find culprit. Changelog: [Internal] Reviewed By: sbuggay Differential Revision: D57473295 fbshipit-source-id: 979f1b9a51f5550a8d3ca534276ec191a3cb7b9e