mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
88a1b8e18d
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/35792 This Diff fixes a problem we have when running Ruby tests. The previous approach was monkey-patching the Ruby File and Dir classes to override some behaviours we needed during tests. However, these classes are also used by the test runners to properly read and run the tests, therefore when the tests were failing, the stream weren't closed properly and we received the wrong errors. This problem was also preventing us from adopting other Ruby tools like SimpleCov to compute code coverage. ## Changelog: [internal] - refactor Ruby tests not to monkey patch Dir and File Reviewed By: dmytrorykun Differential Revision: D42414717 fbshipit-source-id: 879b9928da1a083ebf9c81b1f510eaa039376042
189 lines
7.4 KiB
Ruby
189 lines
7.4 KiB
Ruby
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
#
|
|
# This source code is licensed under the MIT license found in the
|
|
# LICENSE file in the root directory of this source tree.
|
|
|
|
require_relative "./helpers.rb"
|
|
|
|
# Utilities class for React Native Cocoapods
|
|
class ReactNativePodsUtils
|
|
def self.warn_if_not_on_arm64
|
|
if SysctlChecker.new().call_sysctl_arm64() == 1 && !Environment.new().ruby_platform().include?('arm64')
|
|
Pod::UI.warn 'Do not use "pod install" from inside Rosetta2 (x86_64 emulation on arm64).'
|
|
Pod::UI.warn ' - Emulated x86_64 is slower than native arm64'
|
|
Pod::UI.warn ' - May result in mixed architectures in rubygems (eg: ffi_c.bundle files may be x86_64 with an arm64 interpreter)'
|
|
Pod::UI.warn 'Run "env /usr/bin/arch -arm64 /bin/bash --login" then try again.'
|
|
end
|
|
end
|
|
|
|
def self.get_default_flags
|
|
flags = {
|
|
:fabric_enabled => false,
|
|
:hermes_enabled => true,
|
|
:flipper_configuration => FlipperConfiguration.disabled
|
|
}
|
|
|
|
if ENV['RCT_NEW_ARCH_ENABLED'] == '1'
|
|
flags[:fabric_enabled] = true
|
|
flags[:hermes_enabled] = true
|
|
end
|
|
|
|
if ENV['USE_HERMES'] == '0'
|
|
flags[:hermes_enabled] = false
|
|
end
|
|
|
|
return flags
|
|
end
|
|
|
|
def self.has_pod(installer, name)
|
|
installer.pods_project.pod_group(name) != nil
|
|
end
|
|
|
|
def self.turn_off_resource_bundle_react_core(installer)
|
|
# this is needed for Xcode 14, see more details here https://github.com/facebook/react-native/issues/34673
|
|
# we should be able to remove this once CocoaPods catches up to it, see more details here https://github.com/CocoaPods/CocoaPods/issues/11402
|
|
installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result|
|
|
if pod_name.to_s == 'React-Core'
|
|
target_installation_result.resource_bundle_targets.each do |resource_bundle_target|
|
|
resource_bundle_target.build_configurations.each do |config|
|
|
config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def self.exclude_i386_architecture_while_using_hermes(installer)
|
|
projects = installer.aggregate_targets
|
|
.map{ |t| t.user_project }
|
|
.uniq{ |p| p.path }
|
|
.push(installer.pods_project)
|
|
|
|
|
|
# Hermes does not support `i386` architecture
|
|
excluded_archs_default = ReactNativePodsUtils.has_pod(installer, 'hermes-engine') ? "i386" : ""
|
|
|
|
projects.each do |project|
|
|
project.build_configurations.each do |config|
|
|
config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = excluded_archs_default
|
|
end
|
|
|
|
project.save()
|
|
end
|
|
end
|
|
|
|
def self.set_node_modules_user_settings(installer, react_native_path)
|
|
Pod::UI.puts("Setting REACT_NATIVE build settings")
|
|
projects = installer.aggregate_targets
|
|
.map{ |t| t.user_project }
|
|
.uniq{ |p| p.path }
|
|
.push(installer.pods_project)
|
|
|
|
projects.each do |project|
|
|
project.build_configurations.each do |config|
|
|
config.build_settings["REACT_NATIVE_PATH"] = File.join("${PODS_ROOT}", "..", react_native_path)
|
|
end
|
|
|
|
project.save()
|
|
end
|
|
end
|
|
|
|
def self.fix_library_search_paths(installer)
|
|
projects = installer.aggregate_targets
|
|
.map{ |t| t.user_project }
|
|
.uniq{ |p| p.path }
|
|
.push(installer.pods_project)
|
|
|
|
projects.each do |project|
|
|
project.build_configurations.each do |config|
|
|
ReactNativePodsUtils.fix_library_search_path(config)
|
|
end
|
|
project.native_targets.each do |target|
|
|
target.build_configurations.each do |config|
|
|
ReactNativePodsUtils.fix_library_search_path(config)
|
|
end
|
|
end
|
|
project.save()
|
|
end
|
|
end
|
|
|
|
def self.apply_mac_catalyst_patches(installer)
|
|
# Fix bundle signing issues
|
|
installer.pods_project.targets.each do |target|
|
|
if target.respond_to?(:product_type) and target.product_type == "com.apple.product-type.bundle"
|
|
target.build_configurations.each do |config|
|
|
config.build_settings['CODE_SIGN_IDENTITY[sdk=macosx*]'] = '-'
|
|
end
|
|
end
|
|
end
|
|
|
|
installer.aggregate_targets.each do |aggregate_target|
|
|
aggregate_target.user_project.native_targets.each do |target|
|
|
target.build_configurations.each do |config|
|
|
# Explicitly set dead code stripping flags
|
|
config.build_settings['DEAD_CODE_STRIPPING'] = 'YES'
|
|
config.build_settings['PRESERVE_DEAD_CODE_INITS_AND_TERMS'] = 'YES'
|
|
# Modify library search paths
|
|
config.build_settings['LIBRARY_SEARCH_PATHS'] = ['$(SDKROOT)/usr/lib/swift', '$(SDKROOT)/System/iOSSupport/usr/lib/swift', '$(inherited)']
|
|
end
|
|
end
|
|
aggregate_target.user_project.save()
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def self.fix_library_search_path(config)
|
|
lib_search_paths = config.build_settings["LIBRARY_SEARCH_PATHS"]
|
|
|
|
if lib_search_paths == nil
|
|
# No search paths defined, return immediately
|
|
return
|
|
end
|
|
|
|
if lib_search_paths.include?("$(TOOLCHAIN_DIR)/usr/lib/swift-5.0/$(PLATFORM_NAME)") || lib_search_paths.include?("\"$(TOOLCHAIN_DIR)/usr/lib/swift-5.0/$(PLATFORM_NAME)\"")
|
|
# $(TOOLCHAIN_DIR)/usr/lib/swift-5.0/$(PLATFORM_NAME) causes problem with Xcode 12.5 + arm64 (Apple M1)
|
|
# since the libraries there are only built for x86_64 and i386.
|
|
lib_search_paths.delete("$(TOOLCHAIN_DIR)/usr/lib/swift-5.0/$(PLATFORM_NAME)")
|
|
lib_search_paths.delete("\"$(TOOLCHAIN_DIR)/usr/lib/swift-5.0/$(PLATFORM_NAME)\"")
|
|
end
|
|
|
|
if !(lib_search_paths.include?("$(SDKROOT)/usr/lib/swift") || lib_search_paths.include?("\"$(SDKROOT)/usr/lib/swift\""))
|
|
# however, $(SDKROOT)/usr/lib/swift is required, at least if user is not running CocoaPods 1.11
|
|
lib_search_paths.insert(0, "$(SDKROOT)/usr/lib/swift")
|
|
end
|
|
end
|
|
|
|
def self.create_xcode_env_if_missing(file_manager: File)
|
|
relative_path = Pod::Config.instance.installation_root.relative_path_from(Pathname.pwd)
|
|
file_path = file_manager.join(relative_path, '.xcode.env')
|
|
if file_manager.exist?(file_path)
|
|
return
|
|
end
|
|
|
|
system("echo 'export NODE_BINARY=$(command -v node)' > #{file_path}")
|
|
end
|
|
|
|
# It examines the target_definition property and sets the appropriate value for
|
|
# ENV['USE_FRAMEWORKS'] variable.
|
|
#
|
|
# - parameter target_definition: The current target definition
|
|
def self.detect_use_frameworks(target_definition)
|
|
if ENV['USE_FRAMEWORKS'] != nil
|
|
return
|
|
end
|
|
|
|
framework_build_type = target_definition.build_type.to_s
|
|
|
|
Pod::UI.puts("Framework build type is #{framework_build_type}")
|
|
|
|
if framework_build_type === "static framework"
|
|
ENV['USE_FRAMEWORKS'] = 'static'
|
|
elsif framework_build_type === "dynamic framework"
|
|
ENV['USE_FRAMEWORKS'] = 'dynamic'
|
|
else
|
|
ENV['USE_FRAMEWORKS'] = nil
|
|
end
|
|
end
|
|
end
|