mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
a8166bd75b
Summary: fix https://github.com/facebook/react-native/issues/35858 ## Changelog 1. Handle not `number` | `string` value passed to `aspectRatio` 2. Add some tests <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [GENERAL] [FIXED] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> Pull Request resolved: https://github.com/facebook/react-native/pull/35859 Test Plan: ## Sample [Sample Repository](https://github.com/mym0404/rn-aspect-ratio-crash-sample) Video  Reviewed By: necolas Differential Revision: D42575942 Pulled By: NickGerleman fbshipit-source-id: 2f7f46e6e3af85146e4042057477cb6d63b3b279
64 lines
1.4 KiB
JavaScript
64 lines
1.4 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @flow
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const invariant = require('invariant');
|
|
|
|
function processAspectRatio(aspectRatio?: number | string): ?number {
|
|
if (typeof aspectRatio === 'number') {
|
|
return aspectRatio;
|
|
}
|
|
if (typeof aspectRatio !== 'string') {
|
|
if (__DEV__) {
|
|
invariant(
|
|
!aspectRatio,
|
|
'aspectRatio must either be a number, a ratio string or `auto`. You passed: %s',
|
|
aspectRatio,
|
|
);
|
|
}
|
|
return;
|
|
}
|
|
|
|
const matches = aspectRatio.split('/').map(s => s.trim());
|
|
|
|
if (matches.includes('auto')) {
|
|
if (__DEV__) {
|
|
invariant(
|
|
matches.length,
|
|
'aspectRatio does not support `auto <ratio>`. You passed: %s',
|
|
aspectRatio,
|
|
);
|
|
}
|
|
return;
|
|
}
|
|
|
|
const hasNonNumericValues = matches.some(n => Number.isNaN(Number(n)));
|
|
if (__DEV__) {
|
|
invariant(
|
|
!hasNonNumericValues && (matches.length === 1 || matches.length === 2),
|
|
'aspectRatio must either be a number, a ratio string or `auto`. You passed: %s',
|
|
aspectRatio,
|
|
);
|
|
}
|
|
|
|
if (hasNonNumericValues) {
|
|
return;
|
|
}
|
|
|
|
if (matches.length === 2) {
|
|
return Number(matches[0]) / Number(matches[1]);
|
|
}
|
|
|
|
return Number(matches[0]);
|
|
}
|
|
|
|
module.exports = processAspectRatio;
|