mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Oscar Franco
91872826f3
Summary: This is a continuation of my [last PR](https://github.com/facebook/react-native/pull/40914) which improved the symbolication of unhandled promise rejections. While I was developing another library I noticed I still got an error stack of the log adding and not of the error itself. The library I'm trying to debug does not throw a standard error object but rather a custom one, but it still contains the stack field. By passing this stack field to the logbox call I was able to get a better symbolicated stack trace. The exact line of the failure is not displayed but at least the correct file is. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [GENERAL] [ADDED] - Unhandled promise rejection - attach non-standard Error object stack info if possible For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: https://github.com/facebook/react-native/pull/42079 Test Plan: Test any unhandled promise rejection with a non-standard error (line 23, toString must not return `[object Error]`) and see if the correct (or at least a better) stack trace is shown. Here is the one I got before and after this change: <img src="https://github.com/facebook/react-native/assets/1634213/3d07faad-9535-42c9-8032-b4d8fe407e88" width="200" /> <img src="https://github.com/facebook/react-native/assets/1634213/2c39bd82-c7a1-4f58-8ac4-5c479bb96b6e" width="200" /> Reviewed By: huntie Differential Revision: D52431711 Pulled By: cipolleschi fbshipit-source-id: be2172d3b1e2fc3f72812faac372c83bc6dface2
74 lines
2.2 KiB
JavaScript
74 lines
2.2 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @flow strict
|
|
*/
|
|
|
|
import typeof {enable} from 'promise/setimmediate/rejection-tracking';
|
|
|
|
import LogBox from './LogBox/LogBox';
|
|
|
|
type ExtractOptionsType = <P>(((options?: ?P) => void)) => P;
|
|
|
|
let rejectionTrackingOptions: $Call<ExtractOptionsType, enable> = {
|
|
allRejections: true,
|
|
onUnhandled: (id, rejection = {}) => {
|
|
let message: string;
|
|
let stack: ?string;
|
|
|
|
// $FlowFixMe[method-unbinding] added when improving typing for this parameters
|
|
const stringValue = Object.prototype.toString.call(rejection);
|
|
if (stringValue === '[object Error]') {
|
|
// $FlowFixMe[method-unbinding] added when improving typing for this parameters
|
|
message = Error.prototype.toString.call(rejection);
|
|
const error: Error = (rejection: $FlowFixMe);
|
|
stack = error.stack;
|
|
} else {
|
|
try {
|
|
message = require('pretty-format')(rejection);
|
|
} catch {
|
|
message =
|
|
typeof rejection === 'string'
|
|
? rejection
|
|
: JSON.stringify((rejection: $FlowFixMe));
|
|
}
|
|
// It could although this object is not a standard error, it still has stack information to unwind
|
|
// $FlowFixMe ignore types just check if stack is there
|
|
if (rejection.stack && typeof rejection.stack === 'string') {
|
|
stack = rejection.stack;
|
|
}
|
|
}
|
|
|
|
const warning = `Possible unhandled promise rejection (id: ${id}):\n${
|
|
message ?? ''
|
|
}`;
|
|
if (__DEV__) {
|
|
LogBox.addLog({
|
|
level: 'warn',
|
|
message: {
|
|
content: warning,
|
|
substitutions: [],
|
|
},
|
|
componentStack: [],
|
|
stack,
|
|
category: 'possible_unhandled_promise_rejection',
|
|
});
|
|
} else {
|
|
console.warn(warning);
|
|
}
|
|
},
|
|
onHandled: id => {
|
|
const warning =
|
|
`Promise rejection handled (id: ${id})\n` +
|
|
'This means you can ignore any previous messages of the form ' +
|
|
`"Possible unhandled promise rejection (id: ${id}):"`;
|
|
console.warn(warning);
|
|
},
|
|
};
|
|
|
|
export default rejectionTrackingOptions;
|