Facebook/react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

History

Eric Rozell 0449630612 Resolve Paper leak on Android (#46896 )

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/46896

On Android Paper UIManager, when calling `ReactRootView.unmountReactApplication`, the ReactRootView tag is unset [here](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L926), before the round trip unmount operation to JS makes it's way back to a `dropView` call on `NativeViewHierarchyManager`.

In practice, this means that legacy architecture apps that unmount surfaces via `ReactRootView.unmountReactApplication` leak references to Views, and the "finalization" step (`onDropViewInstance`) is not universally called.

This is an attempt to fix the issue by skipping the `clearReactRoot` step on Paper, instead waiting for the round trip `UIManager.removeRootView` call.

## Changelog

[Android][Fixed] Fix issue where `onDropViewInstance` cleanup was not being handled after `ReactRootView.unmountReactApplication`

Reviewed By: javache

Differential Revision: D64054042

fbshipit-source-id: b8b8c237796674ca23a332e57a1bf2e07ab5af13

2024-10-09 05:25:10 -07:00

..

…

Replace React$Element that will cause an error in the future

2024-08-05 18:42:05 -07:00

Bump AGP to 8.7.0 (#46886 )

2024-10-08 10:59:40 -07:00

add support for iOS "Darker System Colors" (Increase Contrast) setting into AccessibilityInfo (#46826 )

2024-10-04 11:46:10 -07:00

remove '$TEMPORARY$array' (#46897 )

2024-10-08 16:33:45 -07:00

rn | Remove set but unused variable. (#46891 )

2024-10-08 12:48:45 -07:00

Resolve Paper leak on Android (#46896 )

2024-10-09 05:25:10 -07:00

Factor out the CXX language standard in a separate const (#45374 )

2024-07-11 05:25:38 -07:00

feat: Add CallInvoker to installJSIBindings(..)/BindingsInstaller (#46851 )

2024-10-09 04:36:04 -07:00

Let .xcode.env.local NODE_BINARY handle path spaces

2024-10-09 04:14:31 -07:00

sdks/hermes-engine

fix(iOS): fallback to old path when dynamic resolve fails (#46432 )

2024-09-13 09:44:19 -07:00

RN][Android] Add a ReactNativeFeatureFlag to enable/disable LayoutAnimations in Android (#46904 )

2024-10-08 16:11:12 -07:00

third-party-podspecs

Inhibit warning in 3p libraries (#46464 )

2024-09-13 08:19:55 -07:00

RN: Migrate to HostInstance Type (#46742 )

2024-10-01 22:51:48 -07:00

build.gradle.kts

configure to build from source (#44920 )

2024-06-13 04:51:20 -07:00

cli.js

cli: fix init when called as npx react-native init (#46677 )

2024-09-27 03:38:19 -07:00

gradle.properties

…

index.js

RN: Migrate to HostInstance Type (#46742 )

2024-10-01 22:51:48 -07:00

interface.js

…

jest-preset.js

Switch Babel parsing from legacy Flow plugin to hermes-parser (#46696 )

2024-09-27 10:20:19 -07:00

LICENSE

…

metro.config.js

…

package.json

Update hermes-parser and related packages in fbsource to 0.24.0 (#46802 )

2024-10-03 08:20:16 -07:00

React-Core.podspec

fix(iOS): move boost compiler flags and folly dep name to centralized config (#46513 )

2024-09-17 04:57:36 -07:00

react-native.config.js

Remove @react-native-community/cli direct dependencies (#45927 )

2024-08-14 12:55:50 -07:00

React.podspec

…

README.md

remove the template from react-native package (#45008 )

2024-06-17 15:48:09 -07:00

rn-get-polyfills.js

Add Flow to @react-native/polyfills entry point (#44477 )

2024-05-08 06:46:15 -07:00

settings.gradle.kts

…

README.md

Where is the template?

The React Native Template has moved from being shipping inside the react-native package to it's own package: @react-native-community/template.

Why has it moved?

The React Native Frameworks RFC0759 provides background information.

When was it moved?

The 0.75 release.