mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Nick Gerleman 2ddef56902 Fix measurement of uncontrolled TextInput after edit

Summary:
D42721684 (https://github.com/facebook/react-native/commit/be69c8b5a77ae60cced1b2af64e48b90d9955be5) left a pretty bad bug when using Fabric for Android. I missed that in Fabric specifically, on edit we will cache the Spannable backing the EditText for use in future measurement.

Because we've stripped the sizing spans, Spannable measurement has incorrect font size, and the TextInput size will change (collapsing) after the first edit. This effectively breaks any uncontrolled TextInput which does not have explicit dimensions set.

Changelog:
[Android][Fixed] - Fix measurement of uncontrolled TextInput after edit

Reviewed By: sammy-SC

Differential Revision: D43158407

fbshipit-source-id: 51602eab06c9a50e2b60ef0ed87bdb4df025e51e

2023-04-11 15:56:00 +01:00

cmake-utils

Fixing failure building RN codegen CLI on Windows (#34791 )

2022-10-11 13:23:51 +01:00

hermes-engine

Use NMake generator for Hermes build on Windows (#34790 )

2022-10-11 13:24:05 +01:00

libs

Upgrade Android support library to version 28 in RN

2019-01-22 10:44:53 -08:00

src

Fix measurement of uncontrolled TextInput after edit